Restore rescaling opacity to B&C editor#27
Merged
Wei (Celia) Xu (celiafish) merged 1 commit intoJun 15, 2026
Conversation
This was originally removed in d031416, since I originally thought it did not make sense for a B&C editor to also modify opacity. Users are actually expecting and relying on this, however, and adjusting the opacity to hide the voxels below the minimum is necessary for thresholding them out. Thus, we are restoring this behavior. Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
5 tasks
Patrick Avery (psavery)
added a commit
to conda-forge/tomviz-feedstock
that referenced
this pull request
Jun 13, 2026
Picks up recent OpenChemistry/tomviz 3.0 commits, including the restored B&C-editor opacity rescaling (NSLS2/tomviz#27, commit 1ec84e1). Signed-off-by: Patrick Avery <patrick.avery@kitware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally removed in d031416, since I originally thought it did not make sense for a B&C editor to also modify opacity.
Users are actually expecting and relying on this, however, and adjusting the opacity to hide the voxels below the minimum is necessary for thresholding them out. Thus, we are restoring this behavior.