Resolve issue where defining executable in module would cause it to be marked as None, also allow for setting ioc template directory in module#261
Open
Jakub Wlodek (jwlodek) wants to merge 1 commit into
Conversation
…e marked as None, also allow for setting ioc template directory in module
Jakub Wlodek (jwlodek)
requested review from
Dmitri Gavrilov (dmgav) and
Jennefer Maldonado (jennmald)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Ansible-based IOC deployment flow to (1) correctly resolve an IOC executable when it is specified in an installed module definition, and (2) allow an installed module to define the IOC template root directory used by deploy_ioc.
Changes:
- Extends the
install_moduleschema and module vars to supportioc_template_root_path, and exposes it as aninstall_module_leaf_*fact. - Refactors
deploy_iocexecutable and template root path resolution to use explicit priority (default → module → role vars → instance/host config). - Updates the
rbd9103IOC to rely on module-provided template root path instead of a role var override.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| schemas/install_module.yml | Adds ioc_template_root_path to the module schema. |
| roles/install_module/vars/rbd9103_a835e1c.yml | Sets module-level ioc_template_root_path for rbd9103. |
| roles/install_module/tasks/install-module.yml | Publishes the module’s IOC template root path as a leaf fact when configured. |
| roles/deploy_ioc/vars/rbd9103.yml | Removes the role-level template root path override so module-level config can drive it. |
| roles/deploy_ioc/tasks/set-facts.yml | Introduces new override-priority resolution logic for executable and template root path. |
| roles/deploy_ioc/defaults/main.yml | Switches to null defaults and adds *_default_ variables for resolution logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+35
to
+39
| # that are not yet defined. | ||
| - name: Detect role-level overrides | ||
| ansible.builtin.set_fact: | ||
| deploy_ioc_executable_role_set_: "{{ deploy_ioc_executable is not none }}" | ||
| deploy_ioc_template_root_path_role_set_: "{{ deploy_ioc_template_root_path is not none }}" |
Jennefer Maldonado (jennmald)
approved these changes
Jun 18, 2026
Jennefer Maldonado (jennmald)
left a comment
Jennefer Maldonado (jennmald)
left a comment
Contributor
There was a problem hiding this comment.
Tested using CMS Cam-03 and verified "none" variables were not present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.