Optimization Cycle I: Loop merge & transient refine#465
Draft
FlorianDeconinck wants to merge 45 commits into
Draft
Optimization Cycle I: Loop merge & transient refine#465FlorianDeconinck wants to merge 45 commits into
FlorianDeconinck wants to merge 45 commits into
Conversation
…lInTasklet` Move re-usable functions into `tree_common_op`
Move pipeline defaults inside the Pipeline itself and have orchestration call default Mockup of passes required for merging to behave
Use symbols in the replacement directory. Update DaCe to a version that doesn't re-initialize the symbols. And fix the test failure in python 3.13.
This has been replaced with `InlineOffgridConditionals` pass
- Local are no longer transient on GPU - RefineTransients is deactivated
Also adds infrastructure to override the orchestration pipeline in tests (used to allow testing `InlineVertical2Dwrite`).
While the functions creates an inconstent DaceConfig by creating a config first and then tempering with some properites without re-evaluating computed properties. In particular `code_path`, `do_compile` and distributed caches are potentially out of sync with the layout information.
…NDSL into opt_cycle_I/loop_merge
UW translate test compares a scalar value (`dotransport`) as part of the translate test. Doing so trips reporting and this change makes it work again \o/
…st" not "exactly" the rank number
Protect `performance_timer` for `time==False` and add external setup
Split Simplify2 pass into a GPU centric with block_size on maps & apply_gpu_xform Remove useless code - legacy code bleed Verbose the steps better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Readying for mainline the following Schedule Tree transform:
CartesianMergeInlineVertical2DWriteCartesianRefineTransientsQOL / Tooling:
TreeOptimizationStatisticswill record the before/after count of maps, fors and transients🐞 Regression/ Bugs worked around
Locals are now non-transient in GPU because of bugs showing during tree optimizationCartesianRefineTransientsis not applied on GPU - same as aboveHow has this been tested?
New tests when needed
Checklist