Skip to content

Physics (PBL-SATMEDF) Update for Explicit Subcanopy Effects on Chemical Tracers#1056

Merged
DusanJovic-NOAA merged 50 commits into
NOAA-EMC:developfrom
noaa-oar-arl:feature/aqm_canopy_vdf
Feb 27, 2026
Merged

Physics (PBL-SATMEDF) Update for Explicit Subcanopy Effects on Chemical Tracers#1056
DusanJovic-NOAA merged 50 commits into
NOAA-EMC:developfrom
noaa-oar-arl:feature/aqm_canopy_vdf

Conversation

@drnimbusrain

Copy link
Copy Markdown
Contributor

Description

This PR facilitates updates the current integrated subcanopy effect (previously merged PR #928 ) to use a more robust, explicit, 3-layer subcanopy effect on chemical tracers (ONLY) in the ccpp-physics, PBL-SATMEDMF scheme. The vegetative canopy modulates vertical diffusion. We split the diffusion on 3 sub-canopy layers with variable height located at 1, 0.5 and 0.2 canopy height (based on Makar et al. 2017), while ensuring mass conservation before returning to the original model layers (for advection, deposition, other physical processes). This leads to a more pronounced effect on the transport of chemical tracers, particularly those as precursors to near-surface ozone formation in the UFS-AQM configuration.

Issue(s) addressed

#1055

Testing

Tested on GaeaC6 with SRW-App AQM configuration.

Are the changes covered by regression tests?
Yes, AQM regression tests with 'do_canopy' added to UWM.

Have the ufs-weather-model regression test been run? On what platform?
Not yet.

  • Will the code updates change regression test baseline?
    N/A

Dependencies

https://github.com/noaa-oar-arl/ufs-weather-model/tree/feature/aqm_canopy_vdf
https://github.com/noaa-oar-arl/ccpp-physics/tree/feature/aqm_canopy_vdf

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
TBD.

@iri01

Irena Ivanova and others added 25 commits November 11, 2025 13:28
@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

@grantfirl @dustinswales Could one of you take a look at this PR and give an approval if it seems ready?

@dustinswales dustinswales left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I do have one small question about allocating the fields

Comment thread ccpp/data/GFS_typedefs.F90 Outdated

@dustinswales dustinswales left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes!

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

@drnimbusrain The CCPP PR has been merged. Please revert .gitmodules and update the CCPP hash to 9e70979.

@drnimbusrain

drnimbusrain commented Feb 27, 2026 via email

Copy link
Copy Markdown
Contributor Author

@drnimbusrain

Copy link
Copy Markdown
Contributor Author

@gspetro-NOAA OK. .gitmodules reverted and updated ccpp hash.

@gspetro-NOAA

Copy link
Copy Markdown
Collaborator

This PR can be merged. Tests completed successfully on ufs-community/ufs-weather-model#3060. The CCPP sub-PR has been merged, .gitmodules reverted, and CCPP hash updated.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 071307b into NOAA-EMC:develop Feb 27, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants