Physics (PBL-SATMEDF) Update for Explicit Subcanopy Effects on Chemical Tracers#1056
Merged
DusanJovic-NOAA merged 50 commits intoFeb 27, 2026
Merged
Conversation
…arl/fv3atm into feature/aqm_canopy_vdf
…vdf' into feature/aqm_canopy_vdf
…arl/fv3atm into feature/aqm_canopy_vdf
This was referenced Jan 20, 2026
…vdf' into feature/aqm_canopy_vdf
…vdf' into feature/aqm_canopy_vdf
Collaborator
|
@grantfirl @dustinswales Could one of you take a look at this PR and give an approval if it seems ready? |
dustinswales
requested changes
Feb 20, 2026
dustinswales
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
I do have one small question about allocating the fields
…arl/fv3atm into feature/aqm_canopy_vdf
dustinswales
approved these changes
Feb 20, 2026
dustinswales
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making these changes!
Collaborator
|
@drnimbusrain The CCPP PR has been merged. Please revert .gitmodules and update the CCPP hash to 9e70979. |
Contributor
Author
|
Thank you for the update! Will do
…On Fri, Feb 27, 2026, 1:41 PM Gillian Petro ***@***.***> wrote:
*gspetro-NOAA* left a comment (NOAA-EMC/ufsatm#1056)
<#1056 (comment)>
@drnimbusrain <https://github.com/drnimbusrain> The CCPP PR has been
merged. Please revert .gitmodules and update the CCPP hash to 9e70979
<ufs-community/ccpp-physics@9e70979>
.
—
Reply to this email directly, view it on GitHub
<#1056 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNWK6WNMHHYWC2K47YT4OCFT5AVCNFSM6AAAAACSKSWRA6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNZUGQ3DSNJQGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
@gspetro-NOAA OK. .gitmodules reverted and updated ccpp hash. |
Collaborator
|
This PR can be merged. Tests completed successfully on ufs-community/ufs-weather-model#3060. The CCPP sub-PR has been merged, |
DusanJovic-NOAA
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR facilitates updates the current integrated subcanopy effect (previously merged PR #928 ) to use a more robust, explicit, 3-layer subcanopy effect on chemical tracers (ONLY) in the ccpp-physics, PBL-SATMEDMF scheme. The vegetative canopy modulates vertical diffusion. We split the diffusion on 3 sub-canopy layers with variable height located at 1, 0.5 and 0.2 canopy height (based on Makar et al. 2017), while ensuring mass conservation before returning to the original model layers (for advection, deposition, other physical processes). This leads to a more pronounced effect on the transport of chemical tracers, particularly those as precursors to near-surface ozone formation in the UFS-AQM configuration.
Issue(s) addressed
#1055
Testing
Tested on GaeaC6 with SRW-App AQM configuration.
Are the changes covered by regression tests?
Yes, AQM regression tests with 'do_canopy' added to UWM.
Have the ufs-weather-model regression test been run? On what platform?
Not yet.
N/A
Dependencies
https://github.com/noaa-oar-arl/ufs-weather-model/tree/feature/aqm_canopy_vdf
https://github.com/noaa-oar-arl/ccpp-physics/tree/feature/aqm_canopy_vdf
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
TBD.
@iri01