Fix no central orders and completely empty grids in scale variations#248
Conversation
|
@kamillaurent Could you please check with this branch (say for one of the datasets and sub-theories that failed before) that it is no longer an issue? |
|
@Radonirinaunimi I checked and seems the problem is no longer there. However, for these datasets: I still encounter the second error: |
|
Could you please try now @kamillaurent ? (Fingers crossed 🤞🏼 it won't break the nFONLL combinations) |
|
@Radonirinaunimi the fix worked and I could compute the remaining ekos and FK Tables. |
|
AFAIC, this is ready to go. |
scarlehoff
left a comment
There was a problem hiding this comment.
Thank you for this. I mostly get the gist of it now that I have the issue in mind but I think I will have no idea why we are returning empty/none things in a year 😅
scarlehoff
left a comment
There was a problem hiding this comment.
Thank you very much for the detailed explanations.
|
@felixhekhorn are you happy with this? |
This PR fixes two issues arising from specific grids during scale variations, namely:
PS: It also bumps the version of
pineappltov1.4.0a1for the tests.