Update PineAPPL version to v1#2217
Conversation
|
sorry, wouldn't it be better to instead of having a branch here just for the pineko dev branch, to remove for now nnpdf from the pineko dev branch? Or do you need nnpdf there? |
Yes, |
scarlehoff
left a comment
There was a problem hiding this comment.
ok then! I've left some small comments, although it is WIP I thought better to mention these small points sooner rather than later.
Just one question, in principle old fktables we will always be able to read, right?
Thanks for the comments @scarlehoff!
Yes, old FK tables will still be read as before perfectly. The only difference is that now when PineAPPL reads these FK tables it'll add onto them the new attributes (for e.g. |
8139253 to
c575fa5
Compare
|
As of |
|
This needs to be rebased to ensure that everything works. I would say let's ignore here the fact that pineappl>=1.0 is not compatible with eko>=0.15 since they never need to talk for this repo (it is only a problem for pineko, but pineko depends only on nnpdf-data not in the full nnpdf) |
|
How is PineAPPL incompatible with EKO? |
|
It was mentioned in the last code meeting, but I don't know the details. |
7d6dfc8 to
15a6eb6
Compare
|
Probably that's off-topic, but I just wanted to mention that with pineappl v1, we need to update the API extension notebook too. I was thinking that this branch might be the most appropriate place to update it. I can take care of that if you don't mind. |
Yes, sure. PS: There isn't a conda version of v1 yet so for the time being please just ignore the failing tests. |
15a6eb6 to
51a8d56
Compare
51a8d56 to
3b87df2
Compare
|
If you could update this as well https://github.com/NNPDF/nnpdf/blob/master/validphys2/examples/API_extension_Pineappl.ipynb before merging that would be great. Otherwise I can have a go tomorrow or the day after and merge it then. |
|
Greetings from your nice fit 🤖 !
Check the report carefully, and please buy me a ☕ , or better, a GPU 😉! |
For the time being, this is primarily needed because
pineko(NNPDF/pineko#206) depends on it. This does not introduce physic's changes yet, ie still does not allow for an arbitrary number of convolutions.