Feat/dev 3737 matrix update - #300
Conversation
| - macos-latest | ||
| - ubuntu-latest | ||
| - windows-latest |
There was a problem hiding this comment.
These may or may not be the best options. For a list of options, see:
There was a problem hiding this comment.
Context: we want to be explicit about the versions we support versus those we don't. For instance, we build for python 3.10 as it is the oldest supported version of python. We want to get in any Ubuntu and Linux that is still under LTS (long term support)
| - ubuntu-20.04 | ||
| - macos-15 | ||
| - macos-26 | ||
| - ubuntu-latest |
There was a problem hiding this comment.
Maybe remove single non-deterministic one?
| @pytest.fixture(scope="class") | ||
| def setup_mock_server() -> None: | ||
| server = Process(target=run_mock_server) | ||
| # MacOS does things differently, so get everyone acting the same way |
There was a problem hiding this comment.
Was this something that changed for mac since py38?
There was a problem hiding this comment.
I can find stuff online saying this change from fork to spawn for just MacOS happened for python 3.8. I don't know how this wasn't an issue for previous builds using python 3.8 on MacOS, but for the build matrix steps, this was causing issues for testing as part of the build process.
| time.sleep(5) # starting with py38, takes longer for process to start on macOS | ||
|
|
||
| # Since py38, a sleep is needed for MacOS. 10 is no longer enough as of py310 | ||
| # Instead of time.sleep(30), this loop could exit faster. |
There was a problem hiding this comment.
Are you seeing a significant reduction in the wait time for this? This increases complexity a bit and I might recommend just going with the 30 sec sleep if we're only saving a couple seconds.
There was a problem hiding this comment.
I can tell a difference on my machine when running sleep(30) instead of this loop, but how often does a person run the tests? Maybe taking longer and being less complex would be preferred
| - develop | ||
| - release/** | ||
| - hotfix/** | ||
| - feat/DEV-3737_Matrix_update |
There was a problem hiding this comment.
This line will be removed at the end, but great call out. I tried to make a comment that would block this merge until this line is deleted, but I couldn't find that option quickly enough so I just kept on moving.
| python -m pip install --upgrade pip | ||
| python -m pip install --no-deps -r requirements.txt | ||
| python -m pip install --no-deps . | ||
| uv sync --locked --extra dev |
There was a problem hiding this comment.
Do we need the dev extras? If so these aren't getting packaged are they?
…/DEV-3737_Matrix_update
| env: | ||
| NO_PROXY: "127.0.0.1,localhost" | ||
| no proxy: "127.0.0.1,localhost" | ||
| run: uv run --with tox-uv tox |
There was a problem hiding this comment.
b/c this isn't a uv project we can just use: uv run tox
| - name: Install dependencies | ||
| run: uv sync | ||
| env: | ||
| UV_DEFAULT_INDEX: https://pypi.org/simple |
|
Due to Jira ticket hooks and slack, I created a new pull request (just tried to change the name really) and it can be found here: |
4 participants
This branch continues on the python 3.10-3.14 update and updates the matrix build process for the new versions of python as well as moving things to uv in the process.