Repository navigation
Conversation
DarianGill
approved these changes
Sep 28, 2026
DarianGill
left a comment
DarianGill
left a comment
Contributor
There was a problem hiding this comment.
This all looks good to me logically, but seeing as there aren't any updates to the actual editor, when I poked around on my local dev browser I wasn't able to confirm functionality interactively--I assume that'll come in part 4. I can confirm all 3057 tests pass and there are no glaring inconsistencies. Appreciate the additional attention to testing and internal viewfinderCard consitency.
robyngit
force-pushed
the
feature-1995-map-editor-part3
branch
from
September 29, 2026 13:35
35c53e2 to
9982140
Compare
robyngit
force-pushed
the
feature-1995-map-editor-part3
branch
from
September 29, 2026 15:18
9982140 to
205db1b
Compare
- Keep original asset shortcut names, icon IDs, and config'ed cesium options. - Ensure we exclude cesium model objects and other properties for interactive/display purposes - Ensure CesiumVectorData doesn't replace the filter config with a filters collection before we can save the original configuration - Add tests including one that verifies that complex configurations can round trip correctly Issue #1995
- Serialize current map settings, layers, categories, and terrains - Exclude temporary drawing assets and keep original viewfinder config for now - Test map and portal configuration round trips Issue #1995
- Serialize card categories, inline cards, and URL sources - Save legacy presets under the current viewfinder keys - Add tests for edits, reloads, and portal map config persistence Issue #1995
- Save the original asset settings instead of changes made while the map is in use - Leave out unused settings while preserving an explicitly disabled outline Issue #1995
robyngit
force-pushed
the
feature-1995-map-editor-part3
branch
from
September 29, 2026 17:52
205db1b to
6d16762
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR saves the current Cesium map configuration when a portal is saved, replacing the placeholder that returned the original unchanged config.
Part of #1995