Make a decent Python package - #6
Conversation
bnlawrence
left a comment
bnlawrence
left a comment
There was a problem hiding this comment.
Looks good. Only query. You've remove the wheel bit. Will this still happily work building the c-bits?
| @@ -1,16 +1,21 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=64", "wheel"] | |||
There was a problem hiding this comment.
@bnlawrence setuptools and pip build wheels so the fairly obsolete "wheel" system backend is not needed anymore; having said that, we really don't want to distribute wheels anyway
There was a problem hiding this comment.
How do folks get the c-version for their platform? Do they have to build it on install, and what happens if they don't have a compiler?
|
I still need to add a GHA test here... |
let's get this one in @bnlawrence - it'll sit inside PyActiveStorage anyway so no point adding more testing bells and whistles to it until then - or do you reckon a GHA CI test would be useful in the meantime for development? |
2 participants
Start making p5rem into a decent Python package, ready for deployment.