Dimensional consistency fixes#438
Merged
Merged
Conversation
gustavo-marques
approved these changes
Jun 8, 2026
gustavo-marques
left a comment
gustavo-marques
left a comment
Collaborator
There was a problem hiding this comment.
@chengz2, great work!
mnlevy1981
approved these changes
Jun 8, 2026
mnlevy1981
left a comment
mnlevy1981
left a comment
Collaborator
There was a problem hiding this comment.
Glad you got the scaling tests to pass, great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With these fixes all dimensions passed the dimensional consistency tests. Some of the fixes are actually unrelated to MOM_CVMix_KPP. Those related to MOM_CVMix_KPP are based on PR #431 which should be merged first.