Repository navigation
feat(mcp): productize one-time proactive-memory setup for chat clients - #1352
harrymove-ctrl wants to merge 2 commits into
Conversation
ducnmm
left a comment
ducnmm
left a comment
There was a problem hiding this comment.
The new local MCP prompt needs a publishable package version before release. This is a static diff/manifest review; I did not rerun the MCP or app test suites.
| return { | ||
| protocolVersion, | ||
| capabilities: { tools: { listChanged: true } }, | ||
| capabilities: { tools: { listChanged: true }, prompts: {} }, |
There was a problem hiding this comment.
[P2] Include a release bump for the changed MCP package
This adds a user-visible prompt capability to the distributed CLI, but the PR leaves the MCP package at 0.0.17 while main already publishes 0.0.18. Merging the code onto current dev still leaves the new behavior on the already-published 0.0.18 unless a new version is included, so existing npm users cannot receive this feature through a new package release. Update the tracked MCP manifests/plugin metadata, paired changelogs and release-verifier pin to a version above the published one.
There was a problem hiding this comment.
Fixed in 6d3574b: bumped packages/mcp and all six plugin and marketplace manifests to 0.0.19 with synchronized CHANGELOG entries while preserving mcpBootstrapVersion 0.0.17-dev.3.
3b58ebe to
6d3574b
Compare
|
Rebased onto dev and prepared publishable MCP 0.0.19 release across package.json, marketplace manifests, plugin manifests, and changelogs. |
Summary
Productizes the one-time proactive-memory consent setup for Claude Desktop chat, Claude web, and other chat clients that do not run plugin lifecycle hooks or inject
initialize.instructionsinto the model prompt:CONSENT_INSTRUCTIONand exposes thememwal_enable_proactiveMCP prompt (prompts/listandprompts/get) in both@mysten-incubation/memwal-mcp(locally in bridge and auth-required modes) and the relayer MCP sidecar (services/server/scripts/mcp)./connect/mcpsuccess screen (ConsentSetupCardinapps/app/src/pages/ConnectMcp.tsx) to guide users through the three one-time setup steps: choosing native vs Walrus Memory, pastingCONSENT_INSTRUCTION, and selectingAlways allowformemwal_rememberandmemwal_remember_bulkafter the first save.apps/app/public/skills/setup,docs/mcp/claude-desktop.md,docs/mcp/claude-connector.md, anddocs/guides/system-prompt-templates.mdwith the unified one-time setup instructions and adds a sync test (packages/mcp/test/consent-instruction-sync.test.mjs) verifying that all six user-pasteable copies ofCONSENT_INSTRUCTIONremain byte-equal.Verification
pnpm --filter @mysten-incubation/memwal-mcp test(335/335passed, includingprompts.test.mjsandconsent-instruction-sync.test.mjs)cd services/server/scripts && npx tsx --test mcp/__tests__/*.test.ts(243/243passed, includingprompts.test.ts)cd apps/app && npx vitest run src/pages/ConnectMcp.test.tsx src/test/setupSkill.test.ts(9/9passed)