Repository navigation
feat(subdomains): allow 1-2 character subnames (#366) - #407
Open
comandanto wants to merge 2 commits into
Open
comandanto wants to merge 2 commits into
comandanto wants to merge 2 commits into
Conversation
…st EInvalidLabelSize with custom config
|
@comandanto is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
hey, friendly ping: is there anything I should change to get this reviewed or merged? happy to rebase or adjust. thx |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #366
Summary
Lowers the default minimum subdomain label length
MIN_LABEL_SIZEfrom 3 to 1 inpackages/subdomains/sources/config.move.Motivation & Context
a.example.suiorzk.example.sui) reside inside namespaces owned and managed by the parent domain owner.domain.movealready supports 1-character labels (MIN_LABEL_LENGTH = 1).Changes
packages/subdomains/sources/config.move:MIN_LABEL_SIZE: u8 = 1;(was3).EInvalidLabelSizedoc comment.packages/subdomains/tests/unit_tests.move:test_parent_relationships()confirming that 1-character (a.example.sui) and 2-character (zk.example.sui) subnames pass validation underdefault()config.test_invalid_child_label_size_failure()to usenew_config(vector[sui_tld()], 10, 3, ...)with a custommin_label_size = 3to verify thatEInvalidLabelSizecontinues to be properly enforced when configured.