Rewrite process_image rotate_image retransfer_images in Ruby#2135
Draft
Rewrite process_image rotate_image retransfer_images in Ruby#2135
process_image rotate_image retransfer_images in Ruby#2135Conversation
retransfer images as class method establish constants
nimmolo
changed the title
process_image script in Rubyprocess_image rotate_image retransfer_images in Ruby
Convert two ivars to constants
Switch to `original_filepath` etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly easier to maintain and test this way.
Adds several gems:
image_processingallows us to run ImageMagick or Vips commands from rubymini_magickruby-vipsmini_exiftoolruns exiftool commandsexiftool_vendoredincludes an up-to-date version of exiftoolrsync