Skip to content

chore: Xcode Cloud Firebase 설정 파일 복원 - #77

Merged
MoonGoon72 merged 1 commit into
developfrom
chore/firebase-config-from-xcode-cloud
Sep 4, 2026
Merged

MoonGoon72 merged 1 commit into
developfrom
chore/firebase-config-from-xcode-cloud

Conversation

@MoonGoon72

@MoonGoon72 MoonGoon72 commented Sep 4, 2026 •

Copy link
Copy Markdown
Owner

변경 사항

  • Xcode Cloud secret 환경 변수에서 Firebase plist를 Base64 복원
  • plist 문법, 앱 Bundle ID, 권한 600 검증
  • Firebase 설정 파일을 Git에 추적하지 않도록 운영 방식 문서화

검증

  • sh -n 및 diff check 통과
  • 임시 Xcode Cloud checkout에서 plist 복원·Bundle ID·권한 검증
  • Release Simulator build 통과

Summary by CodeRabbit

  • 개선 사항

    • Xcode Cloud 빌드 시 Firebase 설정 파일을 안전하게 복원하고 검증합니다.
    • 잘못된 Base64 형식이나 앱 식별자가 일치하지 않는 설정은 빌드 과정에서 감지됩니다.
    • 복원된 설정 파일은 제한된 권한으로 설치되며, 임시 파일은 작업 후 자동으로 정리됩니다.
  • 문서

    • Firebase 설정 복원 및 검증 절차에 대한 Xcode Cloud 릴리스 워크플로 설명을 보완했습니다.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f736005c-66a7-405a-893a-5025d41bc394

📥 Commits

Reviewing files that changed from the base of the PR and between c872e63 and 4ad256a.

📒 Files selected for processing (2)
  • Tekken8 Frame Data/ci_scripts/ci_post_clone.sh
  • docs/architecture.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: build-and-test
🔇 Additional comments (2)
Tekken8 Frame Data/ci_scripts/ci_post_clone.sh (1)

7-7: LGTM!

Also applies to: 47-55, 66-81

docs/architecture.md (1)

201-201: 🔒 Security & Privacy

추가 조치가 필요하지 않습니다.

현재 checkout에서 Firebase plist는 Git index에 등록되지 않았고 .gitignore 규칙이 적용됩니다.


📝 Walkthrough

Walkthrough

Xcode Cloud post-clone 스크립트가 Firebase plist secret을 복원하고 검증한다. 검증된 파일은 TK8/GoogleService-Info.plist에 권한 600으로 설치된다. 아키텍처 문서가 이 배포 절차를 설명한다.

Changes

Firebase plist 설정

Layer / File(s) Summary
Secret 입력 및 임시 파일 관리
Tekken8 Frame Data/ci_scripts/ci_post_clone.sh
FIREBASE_GOOGLE_SERVICE_INFO_PLIST_BASE64 환경변수를 필수 값으로 확인한다. Firebase plist를 임시 파일에 저장하고 종료 시 삭제한다.
plist 검증 및 설치
Tekken8 Frame Data/ci_scripts/ci_post_clone.sh, docs/architecture.md
Base64, plist 문법, BUNDLE_ID=com.moongoon.TK8을 검증한다. 파일 권한을 600으로 설정한 뒤 원자적으로 설치한다. Xcode Cloud 절차를 문서에 반영한다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 4ad25

The release build now restores Firebase configuration from an Xcode Cloud secret and rejects malformed or mismatched configuration before installation. The documented, validated workflow is ready to merge.

Sequence Diagram(s)

sequenceDiagram
  participant XcodeCloud
  participant ci_post_clone.sh
  participant FirebasePlist
  XcodeCloud->>ci_post_clone.sh: Firebase secret 전달
  ci_post_clone.sh->>FirebasePlist: Base64 디코드
  ci_post_clone.sh->>FirebasePlist: plist 및 BUNDLE_ID 검증
  ci_post_clone.sh->>FirebasePlist: 권한 600으로 원자적 설치
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed 제목은 Xcode Cloud에서 Firebase 설정 파일을 복원하는 주요 변경 사항을 명확하고 간결하게 설명합니다.
Description check ✅ Passed 변경 사항과 검증 내용은 충분히 설명되어 있습니다. 다만 템플릿의 관련 이슈, 고민한 내용, 소요 시간 항목은 포함되지 않았습니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MoonGoon72 MoonGoon72 self-assigned this Sep 4, 2026
@MoonGoon72
MoonGoon72 merged commit b78d77d into develop Sep 4, 2026
2 checks passed
@MoonGoon72
MoonGoon72 deleted the chore/firebase-config-from-xcode-cloud branch September 4, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant