Skip to content

Proposed Fix to Monika forgetting the player was sick if she showers.#10529

Open
TheGamerSide67 wants to merge 2 commits into
Monika-After-Story:masterfrom
TheGamerSide67:patch-3
Open

Proposed Fix to Monika forgetting the player was sick if she showers.#10529
TheGamerSide67 wants to merge 2 commits into
Monika-After-Story:masterfrom
TheGamerSide67:patch-3

Conversation

@TheGamerSide67

Copy link
Copy Markdown
Contributor

No description provided.

@TheGamerSide67 TheGamerSide67 marked this pull request as ready for review February 4, 2026 06:40
@TheGamerSide67

Copy link
Copy Markdown
Contributor Author

This pull request is an attempt at fixing the issue with Monika forgetting the player was sick if the event in which Monika showers when you greet her. It adds a check at the end of the dialogue. It was quickly added, so please review it until it is considered good enough to directly commit to the main branch.

@Booplicate

Booplicate commented Feb 4, 2026

Copy link
Copy Markdown
Member

This doesn't fix the root of the issue. You shouldn't get this greeting if you're sick, so with your fix you're plasterfixing it. As you can see in all paths that player can take we set a greeting type to select on next load: persistent._mas_greeting_type = store.mas_greetings.TYPE_SICK. This makes impossible (or at least should make) to get any greeting except for the ones with the sick type.

Basically with your approach you'd have to add this dialogue path for sick in every other greeting. That'd be incorrect.

@Booplicate Booplicate added this to Bugs Feb 4, 2026
@Booplicate Booplicate moved this to In Progress in Bugs Feb 4, 2026
@TheGamerSide67

Copy link
Copy Markdown
Contributor Author

Gotcha, though it seems that the only way to fix that, would to be to force it every time, even if the event procs. I will relook and give it another go later on when I have the time. I didn't know what the entire intention is, since it does normally work correctly unless Monika decides to shower. This has not happened with any other dialogue that we know of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants