Skip to content

[AMA Topic] Biggest Pet Peeve#10516

Open
lunulae wants to merge 8 commits into
content-12from
lunulae-patch-8
Open

[AMA Topic] Biggest Pet Peeve#10516
lunulae wants to merge 8 commits into
content-12from
lunulae-patch-8

Conversation

@lunulae

@lunulae lunulae commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

I'm surprised how many of the old AMA questions had me really inspired, lmao
I'm a little iffy on the exps, but otherwise I really like this one

@Booplicate Booplicate added this to Topics Jan 3, 2026
@Booplicate Booplicate moved this to Dialogue Review/Code Review/Testing in Topics Jan 3, 2026

@multimokia multimokia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a few things at a glance

m 2dsd "I don't mean by genuine accident. I mean consistently, or when I'm saying something important."
m 4esd "You'd think it might be something that I got used to in debate club, but it was quite the opposite."
m 4eub "Debate club wasn't about shouting over each other, it was a great place for structured discussions."
m 3ltd "...You know, maybe that's why I slowed down the text when we first came here, too."

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should affection check this (mas_isMoniHappy()), since by default when starting MAS, it's still locked to that speed, and if we drop below happy, speed changing is removed from the player's control again

Comment thread Monika After Story/game/script-topics.rpy Outdated
Comment thread Monika After Story/game/script-topics.rpy Outdated
if persistent._mas_pm_listened_to_grad_speech = True:
m 3fka "...{w=0.2}And it's why having you hear out my graduation speech was so important to me."
m 3fkblb "Thank you for giving me your full attention there, it really meant a lot to me."
else:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume this else block was for the line below, but it is not part of the block.

Considering the above conditional is the same, is there a reason this isn't part of the first block?

@lunulae lunulae Jan 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, the else is her not saying anything in that block, just for if they haven't seen the graduation speech at all

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case you would need to check not renpy.seen_label('monika_grad_speech'). This would be True if the player has never been through the speech and False if they have (regardless of if they've paid attention)

m 3fka "...{w=0.2}And it's why having you hear out my graduation speech was so important to me."
m 3fkblb "Thank you for giving me your full attention there, it really meant a lot to me."
else:
m 4dublb "In the end, I know you really do care about hearing what I have to say, [player]."

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
m 4dublb "In the end, I know you really do care about hearing what I have to say, [player]."
m 4dublb "In the end, I know you really do care about hearing what I have to say, [player]."

Comment thread Monika After Story/game/script-topics.rpy Outdated
Comment thread Monika After Story/game/script-topics.rpy Outdated
lunulae and others added 3 commits January 4, 2026 01:32
Co-authored-by: multimokia <misty@multimokia.studio>
Comment thread Monika After Story/game/script-topics.rpy Outdated
Co-authored-by: Spotted Dove <84446131+Wingdinggaster656@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Dialogue Review/Code Review/Testing

Development

Successfully merging this pull request may close these issues.

4 participants