Skip to content

A missing return "derandom" in monika_conventions #10198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wingdinggaster656 wants to merge 2 commits into
base: content-12
Choose a base branch
from
Open

A missing return "derandom" in monika_conventions #10198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a5b2d
A missing` return "derandom"`
Wingdinggaster656 Feb 13, 2024
ccafefa
Update updates.rpy
Wingdinggaster656 Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Monika After Story/game/script-topics.rpy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17915,7 +17915,7 @@ label monika_conventions:
m 1wuo "It's crazy what people can do when they're passionate about something!"
m 3eua "I also hear there's a lot of fun activities like idol dance shows, trivia, and other things to do there."
m 1eubsa "I would love to go to one with you someday, [mas_get_player_nickname()]~"
return
return "derandom"

init 5 python:
addEvent(
Expand Down
3 changes: 2 additions & 1 deletion Monika After Story/game/updates.rpy
View file
Open in desktop

@dreamscached dreamscached Feb 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MonikaModDev/Monika After Story/game/updates.rpy

Lines 378 to 382 in ccafefa

label v0_12_15(version="v0_12_15"):
python hide:
if mas_seenEvent("monika_conventions"):
mas_hideEVL("monika_conventions", derandom=True)
return

Better leave that to maintainers. We have no idea if the next release would be 0_12_x or 0_13_x ahead of time. This line will have no effect as the proposed changes did not appear in 0.12.15.

Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,8 @@ label v0_3_1(version=version): # 0.3.1
# 0.12.15
label v0_12_15(version="v0_12_15"):
python hide:
pass
if mas_seenEvent("monika_conventions"):
mas_hideEVL("monika_conventions", derandom=True)
return

# 0.12.13
Expand Down