fix: update xgboost api and add depends R>=4.1.0 to description#51
fix: update xgboost api and add depends R>=4.1.0 to description#51pbiecek merged 13 commits intoModelOriented:masterfrom
Conversation
|
Note: |
|
Edit: It's related to how they handle the intercept now
(https://xgboost.readthedocs.io/en/stable/tutorials/intercept.html#intercept) I will propose a fix soon in this PR |
restored expected behaviour of 'predictions from unified == original predictions' by now controlling the 'base_score' parameter in order to prevent automated calculation of the intercept, as it was introduced to xgboost with v2 and later versions
renamed argument 'model' -> 'model_name' to avoid issues with also used object named 'model'
as split value is considered to be 'less than'
…nning of test-files
…or conditional testing
|
@mayer79 I was able to fix everything related to the failing CRAN stuff and related to the new xgboost API. However, to restore the behaviour of the previous xgboost version in the unit tests, some hacky workaround was necessary (5ba814a#diff-b1f4725ec5309708f3632330acf3ef5551186dec8b62919e6209af8b0eda42daR160-R179) In short:
As I considered the latter more improtant, I've implemented everything in a manner that those tests work well and created the hacky workaround only for the two tests referenced above (not sure if they are really required though?!). Would be great if you or one of the maintainers could have a look at those changes. Best, |
renamed globals.R -> zzz.R and moved all import statements there
This PR fixes the cause of the CRAN note, for which treeshap was removed from CRAN in 12/2025.
Would be nice if one of the maintainers could submit this package again please.
Best, Lorenz
@pbiecek @piotrpiatyszek @tmikolajczyk @krzyzinskim