Skip to content

add tm1637 7-segment LED display - #1677

Closed
stc1988 wants to merge 2 commits into
Moddable-OpenSource:publicfrom
stc1988:driver/tm1637
Closed

add tm1637 7-segment LED display#1677
stc1988 wants to merge 2 commits into
Moddable-OpenSource:publicfrom
stc1988:driver/tm1637

Conversation

@stc1988

@stc1988 stc1988 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

I confirmed with Seed 4-Digit Display.

@stc1988

stc1988 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author
trim.1D3B2A9E-5839-4F0A-8DAC-D4E91ADAFFB2.MOV

@phoddie phoddie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks really good and follows the ECMA-419 conventions well.

I added some comments for your consideration.

Comment thread modules/drivers/peripherals/tm1637/tm1637.js Outdated
Comment thread modules/drivers/peripherals/tm1637/tm1637.js Outdated
Comment thread modules/drivers/peripherals/tm1637/tm1637.js Outdated
Comment thread modules/drivers/peripherals/tm1637/tm1637.js Outdated
Comment thread modules/drivers/peripherals/tm1637/tm1637.js
Comment thread modules/drivers/peripherals/tm1637/tm1637.js Outdated
@stc1988

stc1988 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the review. I had AI check whether the implementation followed the Guide, but it seems to have missed it. As for onError, the same can be said for qwiic_alphanumeric.js, which I used as a reference.

I have addressed the points you pointed out, so could you please check them?

@phoddie

phoddie commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Thank you for the changes. It looks good now.

We'll look at updating the qwiic peripheral you modeled this on. You demonstrate why correct code, not just working code, is important: people (and their LLMs) assume existing code is a good model. But, neither checks the documentation. ;)

@mkellner

Copy link
Copy Markdown
Collaborator

This has been merged and will be available in the next release.

@mkellner mkellner closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants