add tm1637 7-segment LED display - #1677
Conversation
trim.1D3B2A9E-5839-4F0A-8DAC-D4E91ADAFFB2.MOV |
phoddie
left a comment
There was a problem hiding this comment.
Overall this looks really good and follows the ECMA-419 conventions well.
I added some comments for your consideration.
|
Thank you for the review. I had AI check whether the implementation followed the Guide, but it seems to have missed it. As for I have addressed the points you pointed out, so could you please check them? |
|
Thank you for the changes. It looks good now. We'll look at updating the qwiic peripheral you modeled this on. You demonstrate why correct code, not just working code, is important: people (and their LLMs) assume existing code is a good model. But, neither checks the documentation. ;) |
|
This has been merged and will be available in the next release. |
I confirmed with Seed 4-Digit Display.