Repository navigation
fix: preserve builtin and active-agent skill resource reads - #231
Merged
Merged
Conversation
Allow read-only access to designated skill roots while retaining private-state and symlink guards. Cover permission modes and resource operations through the runtime facade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
After the private-runtime read guard was introduced, bundled skills under
.builtin-skillsand the active agent's skills underagents/<agent>/skillsunexpectedly required approval when reading their references or templates in default/auto permission modes.Recognize these roots in both the private-state guard and the facade's read-only allow paths. Keep other agents' private roots, runtime state, similarly named sibling directories, and credential/private-state symlink targets behind approval. Full-access behavior is unchanged.
Validation
askinstead ofallow); all 142 permission facade tests pass after the fix. Coverage includes read/grep/glob/list, global/builtin/active-agent roots, permission modes, private-state isolation, and file/root symlinks.pnpm verifyon committedfdf164510ece1404ac6127491b25db25bb31979con macOS arm64 / Node 26: all 14 gates passed. The initial shared-dependency setup failed the sandbox manifest lookup; installing the frozen lockfile into this worktree resolved it, and the complete profile passed on rerun.Publication and contribution checks
Maintainer handoff
Publication scope and licensing are unchanged. Shared-source port: complete. Merge/release remains a maintainer action.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.