fix : close command fails to execute on Hyperliquid#13
Open
tae9898 wants to merge 4 commits into
Open
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Problem
minara perps close returns success but positions remain open on Hyperliquid.
##Cause
Close order uses trigger (take-profit) type which Hyperliquid doesn't execute:
t: { trigger: { triggerPx: String(marketPx), tpsl: 'tp', isMarket: true } }
Fix
Changed to limit IOC (Immediate or Cancel) in src/commands/perps.ts (lines 944, 1055):
t: { limit: { tif: 'Ioc' } }
This fills immediately at market price