-
Notifications
You must be signed in to change notification settings - Fork 458
Update parameters for logical network creation #4276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,14 +82,14 @@ Create a static logical network when you want to create Azure Local VMs with net | |
|
|
||
| ```azurecli | ||
| $lnetName = "mylocal-lnet-static" | ||
| $internalNetworkName = "<Layer 3InternalNetwork>" | ||
| $fabricResourceID = "<Layer 3InternalNetworkID>" | ||
| $subscription = "<Subscription ID>" | ||
| $resource_group = "mylocal-rg" | ||
| $customLocationID = "/subscriptions/<Subscription ID>/resourceGroups/mylocal-rg/providers/Microsoft.ExtendedLocation/customLocations/mylocal-cl" | ||
| $location = "eastus" | ||
| $addressPrefixes = "100.68.180.0/28" | ||
| $ipPoolEnd = "100.68.180.20" | ||
| $ipPoolStart = "100.68.180.10" | ||
| $ipPoolEnd = "100.68.180.20" | ||
| $dnsServers = "192.168.200.222" | ||
| $vlan = "201" | ||
| ``` | ||
|
|
@@ -121,8 +121,7 @@ Create a static logical network when you want to create Azure Local VMs with net | |
| 1. Create a static logical network. Run the following command: | ||
|
|
||
| ```azurecli | ||
| az stack-hci-vm network lnet create --subscription $subscription --resource-group $resource_group --custom-location $customLocationID --location $location --name $lnetName --ip-allocation-method "Static" --address-prefixes $addressPrefixes --no-gateway | ||
| --ip-pool-start $ipPoolStart --ip-pool-end $ipPoolEnd --ip-pool-type "vm" --dns-servers $dnsServers --fabric-network-configuration-id $fabricResourceID --vlan $vlan | ||
| az stack-hci-vm network lnet create --subscription $subscription --resource-group $resource_group --custom-location $customLocationID --location $location --name $lnetName --ip-allocation-method "Static" --address-prefixes $addressPrefixes --no-gateway --ip-pool-start $ipPoolStart --ip-pool-end $ipPoolEnd --ip-pool-type "vm" --dns-servers $dnsServers --fabric-network-configuration-id $fabricResourceID --vlan $vlan | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kerimhanif thanks for making the tweak to add the space between the parameters. Apart from that, I notice in this PR fork the gateway input is given as --no-gateway whereas in public docs on what is live it is like below in the link here: https://learn.microsoft.com/en-us/azure/azure-local/multi-rack/multi-rack-create-logical-networks?view=azloc-2606 --gateway $gateway I'd leave it as it the same way as it is on the live doc. @ronmiab FYI
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sipastak FYR as you are reviewer on this. |
||
| ``` | ||
|
|
||
| Here's a sample output: | ||
|
|
@@ -199,4 +198,4 @@ Create a static logical network when you want to create Azure Local VMs with net | |
|
|
||
| ## Next steps | ||
|
|
||
| - [Create Azure Local VMs enabled by Azure Arc](./multi-rack-create-arc-virtual-machines.md) | ||
| - [Create Azure Local VMs enabled by Azure Arc](./multi-rack-create-arc-virtual-machines.md) | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ronmiab I like the change AI is recommending here; however, the ARM ID shape is not quite right in the example. Can you change it to say this instead for the $fabricResourceID example?
"/subscriptions//resourceGroups/mylocal-rg/providers/Microsoft.ManagedNetworkFabric/l3IsolationDomains/<Layer 3 Isolation Domain> /internalNetworks/"
I am unable to edit this fork. Don't seem to have permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sipastak FYR as you are reviewer on this.