Artifact#1
Open
MichaelTimbert wants to merge 43 commits into
Open
Conversation
Merge pull request zonemaster#1232 from zonemaster/develop
MichaelTimbert
force-pushed
the
artifact
branch
from
62665e3 to
514da24
Compare
The latest version of Perl is now 5.42. Let’s bump the topmost version in the list of Perls tested against in CI to that.
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com>
Co-authored-by: Marc van der Wal <103426270+marc-vanderwal@users.noreply.github.com> Output testagent log on stdout/stderr.
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
…lation Updates Swedish PO file
URL to TLD for GUI
Docker related improvement.
Changes to the cache file format in Zonemaster::Engine require regeneration of some data files in use by the test suite in Zonemaster-Backend. There also was a small mistake in the logic that decides whether to save or restore data from the corresponding data files. Restoration should not be attempted if ZONEMASTER_RECORD=1 is not set in the environment, and likewise, the data files should not be written to if that same variable isn’t in the environment.
…a-file-update Update data file format
Add schema version
* Let systemd take care of daemonization. Invoke zonemaster_backend_testagent with `foreground` instead of `start`/`stop`, --pidfile and --outfile. This allows journald to capture the output from STDOUT/STDERR. * Let journald collect logs. Setting --logfile=- causes logs to be written to STDOUT, which is captured by journald. * Let systemd take care of privilege dropping. By specifying User=zonemaster and Group=zonemaster, zonemaster_backend_testagent can execute entirely without root privileges.
* Let systemd take care of daemonization. Invoke zonemaster_backend_rpcapi.psgi without --daemonize and --pid. This allows journald to capture STDOUT/STDERR. * Let journald collect logs. Since journald already captures STDOUT/STDERR we can just write our logs there. * Let systemd take care of privilege dropping. By setting User= and Group= in the unit file, instead invoking zonemaster_backend_rpcapi.psgi with --user and --group, the process can be started without elevated privileges.
* Fix help text * Add forgotten dependency * Add documentation and unit test for Zonemaster::Backend::Log * Clean up unit test
Add artifact build to the CI
Systemd integration
…5.42 CI: Target Perl version 5.42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR...
Context
(e.g. Fixes #9999, Follow-up to #9999, etc.)
Changes
...
How to test this PR
...