ci: Upgrade Yarn to 4.16.0 and update action-npm-publish to v6 - #92
Merged
Merged
Conversation
Mrtenz
force-pushed
the
mrtenz/action-npm-publish@v6
branch
from
June 5, 2026 12:26
e3074d2 to
8cda9b2
Compare
Mrtenz
force-pushed
the
mrtenz/action-npm-publish@v6
branch
from
June 8, 2026 10:47
8cda9b2 to
a66f541
Compare
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Mrtenz
marked this pull request as ready for review
June 8, 2026 10:59
cryptodev-2s
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.yarnrc.ymlto match the module templateaction-npm-publishfrom v5 to v6 inpublish-release.ymlNPM_TOKENoptional and addsid-token: writepermissions topublish-npmjobid-token: writepermission topublish-releasejob inmain.ymlNote
Medium Risk
Changes affect the NPM release path (artifact handoff, optional token, OIDC) and CI install/cache behavior; misconfiguration could block releases or produce inconsistent builds, though application runtime code is untouched.
Overview
Standardizes GitHub Actions on
MetaMask/action-checkout-and-setup@v3, replacing separate checkout, Node setup, andyarn installsteps. CI jobs setis-high-risk-environment: false(with optional node module caching on prepare); release jobs usetrue. Build/lint/e2e split snap caching intoactions/cache/saveandactions/cache/restore, and e2e no longer runs a redundant install when restoringdist.main.ymlroutes security scanning toMetaMask/action-security-code-scannerreusable workflow v2 (with explicitpaths-ignoredand renamed secrets), drops the localsecurity-code-scanner.yml, and grantsid-token: writeon the release caller for OIDC publishing.publish-release.ymlis reordered into build → NPM dry run → NPM publish → GitHub release. A single build uploadsdistand.yarn-state.ymlas artifacts; downstream jobs restore them instead of rebuilding.MetaMask/action-npm-publishmoves to v6;NPM_TOKENis optional at the workflow level; the publish job addsid-token: write. GitHub release publishing runs only after a successful NPM publish.Removes the vendored Yarn constraints plugin (
.yarn/plugins/@yarnpkg/plugin-constraints.cjs), consistent with Yarn 4 template alignment described in the PR.Reviewed by Cursor Bugbot for commit 6ee30ee. Bugbot is set up for automated code reviews on this repo. Configure here.