chore: report short-lived connections in snapshots - #3127
Open
xishang0128 wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the WebSocket connections snapshot feed so that connections which open and close between two snapshot pushes are still reported once (in the next snapshot) with their final observed statistics.
Changes:
- Add
SnapshotStreamtotunnel/statistic.Managerand push recently-closedTrackerInfoentries to active streams onLeave. - Update the WebSocket
/connectionsroute to use a per-clientSnapshotStreaminstead of directly callingDefaultManager.Snapshot().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tunnel/statistic/manager.go | Adds snapshot streaming state and logic to include closed-between-snapshots connections in the next snapshot. |
| hub/route/connections.go | Uses a SnapshotStream for the WebSocket connections feed to include short-lived connections. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+32
to
+36
| if err != nil { | ||
| return | ||
| } | ||
| snapshotStream := statistic.DefaultManager.NewSnapshotStream() | ||
| defer snapshotStream.Close() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short-lived connections can open and close between two WebSocket updates, causing them to be missing from the connections list. This change includes them once in the next update with their final traffic statistics.