Fix #1714 putAccelerated errors not being caught#1715
Open
reidsunderland wants to merge 2 commits into
Open
Conversation
…pen code with a wrapper
Test Results360 tests 359 ✅ 1m 50s ⏱️ Results for commit b7f3340. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1714 describes the problem and has example logs. If an accelerated upload failed (
putAccelerated) the error was not caught. Flow would think the transfer succeeded and move on.I replaced the Popen call and return code checking inside the transfer classes with a wrapper method. This reduces some repeated code and captures stderr for better error logging.
getAcceleratedworked fine, but I changed it to use the wrapper function too. Because the download code in Flow correctly deals with-1returned by getAccelerated, I kept that to minimize changes (rather than throwing the Exception up to Flow like putAccelerated does).