Skip to content

Fix MQTT close() blocking indefinitely on pending publishes #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robjarawan wants to merge 6 commits into
base: development
Choose a base branch
from
Open

Fix MQTT close() blocking indefinitely on pending publishes #1650

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
38b410b
Fix MQTT close() blocking indefinitely on pending publishes
robjarawan Mar 30, 2026
8c50125
Merge branch 'development' into fix/mqtt-close-indefinite-block
petersilva Mar 30, 2026
ca75eb8
Merge branch 'development' into fix/mqtt-close-indefinite-block
petersilva Mar 30, 2026
b61835a
Merge branch 'refactor/mqtt-queue-simplify' into fix/mqtt-close-indef…
Apr 13, 2026
a4be80a
Merge branch 'fix/989-special-chars-in-credentials' into fix/mqtt-clo…
Apr 13, 2026
f91e937
Merge branch 'development' into fix/mqtt-close-indefinite-block
robjarawan Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions sarracenia/moth/mqtt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,17 +834,24 @@ def close(self):
time.sleep(0.1)

if hasattr(self, 'pending_publishes'):
ebo=0.1
while len(self.pending_publishes) >0:
logger.info( f'waiting {ebo} seconds for last {len(self.pending_publishes)} messages to publish')
ebo = 0.1
total_wait = 0
max_wait = self.o['timeout'] if self.o.get('timeout') else 300
while len(self.pending_publishes) > 0:
if total_wait >= max_wait:
logger.warning(f'gave up waiting for {len(self.pending_publishes)} pending publishes after {total_wait:.0f}s')
break
logger.info(f'waiting {ebo} seconds for last {len(self.pending_publishes)} messages to publish')
if len(self.unexpected_publishes) < 10:
logger.info( f'messages acknowledged before publish?: {self.unexpected_publishes}')
logger.info(f'messages acknowledged before publish?: {self.unexpected_publishes}')
if len(self.pending_publishes) < 10:
logger.info( f'messages awaiting publish: {self.pending_publishes}')
logger.info(f'messages awaiting publish: {self.pending_publishes}')
time.sleep(ebo)
total_wait += ebo
if ebo < 64:
ebo *= 2
logger.info('no more pending messages')
else:
logger.info('no more pending messages')
self.client.disconnect()
self.client.loop_stop()
self.connected=False
Loading