-
Notifications
You must be signed in to change notification settings - Fork 99
Inland basin flow coupling #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 18 commits
28d07aa
c902936
726ed5a
83bbe0e
e7de852
96e2dd5
021e478
c98ab10
c3cdc1d
df71126
a5a79c3
cdd0fb5
9bbe2f0
7492fbd
820c6d7
0851f3c
fd97d92
c8f7509
1b344a1
6c4f748
b8e46ff
e6e3960
07b3415
b26d85c
b16e78b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
DanCopsey marked this conversation as resolved.
|
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do the changes to the checksums need reverting?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi Maggie (@maggiehendry) . The change to the checksums is still needed as there was a bug in the runoff that this branch also fixes. The runoff should be multiplied by the land fraction in order to conserve water. This changes results. See lines 1058 to 1061 of jules_extra_kernel_mod.F90: I will also add this to the ticket description. Dan.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh yes. I remembering seeing the runoff multiplied by land fraction. Thanks. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| Inner product checksum rho = 411B540AFC3D92A4 | ||
| Inner product checksum theta = 42735B2019E207B8 | ||
| Inner product checksum u = 456F436726BEF558 | ||
| Inner product checksum mr1 = 40368556264483BA | ||
| Inner product checksum mr2 = 3F3FBA123E60797A | ||
| Inner product checksum mr3 = 3F00E9AB1907D0A8 | ||
| Inner product checksum mr4 = 3F368BCAF7E5661C | ||
| Inner product checksum rho = 411B54091A1CCB38 | ||
| Inner product checksum theta = 42735B1EF5533E5B | ||
| Inner product checksum u = 456F432E426C7F82 | ||
| Inner product checksum mr1 = 4036851669A6D9B7 | ||
| Inner product checksum mr2 = 3F3F8C53A08B9212 | ||
| Inner product checksum mr3 = 3F0176E8C7628BD1 | ||
| Inner product checksum mr4 = 3F36A2EEAED985B1 | ||
| Inner product checksum mr5 = 0 | ||
| Inner product checksum mr6 = 0 |
|
DanCopsey marked this conversation as resolved.
|
Uh oh!
There was an error while loading. Please reload this page.