Functions that return SOCKPERF_ERROR are now declared with the right type - #159
Open
dolby360 wants to merge 1 commit into
Open
Functions that return SOCKPERF_ERROR are now declared with the right type#159dolby360 wants to merge 1 commit into
dolby360 wants to merge 1 commit into
Conversation
Also, compare rc with the correct error code
|
Can one of the admins verify this patch? |
Contributor
|
I would actually prefer if return type stays as int, but that's a preference in style. I'd wait to see what the maintainers think. I do agree with the rest of the changes in this file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, compare rc with the correct error code