Repository navigation
Fix: Several bugfixes on the Dark theme - #1265
Merged
Merged
Conversation
Daetha
reviewed
Oct 9, 2026
Daetha
reviewed
Oct 9, 2026
Collaborator
Daetha
approved these changes
Oct 9, 2026
Daetha
left a comment
Collaborator
There was a problem hiding this comment.
Looks astonishing and stilish. Re-using colors as variables in css is a big step towards maintainability. Approved
Introduce --elmo-brand-color and reuse it across buttons, backgrounds, dropdowns, and Tagify styling. Keep brand blue fixed for white-text contrast while heading colors remain theme-aware.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive update to the application's color palette and theming system, focusing on improving consistency and maintainability across both light and dark modes. The changes centralize color variables, enhance support for dark mode, and refactor component-specific styles to use CSS custom properties. This will make it easier to maintain branding and ensure a cohesive look throughout the UI.
Changes
Centralized and Themed Color Variables
--elmo-surface,--elmo-heading-color, and more, incss/gfz-cd.cssandcss/darkmode.css. This enables consistent theming and simplifies future palette adjustments. [1] [2]Enhanced Dark Mode Support
css/darkmode.cssto use the new variables, update Bootstrap dark theme variables, and add targeted component overrides (for cards, modals, dropdowns, buttons, jsTree, autocomplete, etc.) for a more polished and accessible dark mode.Component-Specific Style Refactoring
css/gfz-cd.cssandcss/help.cssto use the new custom properties, ensuring consistent styling across components and between themes. [1] [2] [3] [4] [5]Improved Footer and Layout Responsiveness
Accessibility and Visual Feedback Improvements
Screenshots
Optimized Light Mode
ELMO
Guide
Optimized Dark Mode
ELMO
Guide
Notes for Reviewer
ELMO Guido woes reworked on top.
Checklist
Branching Strategy:
If this is a hotfix: The branch was created from
mainand will be merged intomain.If this is a feature or documentation change: The branch was created from
devand will be merged intodev.If this is a feature or documentation branch, I have pulled the latest changes from
maininto my branch.Code Quality
Documentation
Testing
Known Issues
None.