Skip to content

Fix: Several bugfixes on the Dark theme - #1265

Merged
McNamara84 merged 13 commits into
devfrom
fix/issue-1247
Oct 9, 2026
Merged

McNamara84 merged 13 commits into
devfrom
fix/issue-1247

Conversation

@McNamara84

@McNamara84 McNamara84 commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

This pull request introduces a comprehensive update to the application's color palette and theming system, focusing on improving consistency and maintainability across both light and dark modes. The changes centralize color variables, enhance support for dark mode, and refactor component-specific styles to use CSS custom properties. This will make it easier to maintain branding and ensure a cohesive look throughout the UI.

Changes

Centralized and Themed Color Variables

  • Introduced a shared set of CSS custom properties (variables) for both light and dark themes, such as --elmo-surface, --elmo-heading-color, and more, in css/gfz-cd.css and css/darkmode.css. This enables consistent theming and simplifies future palette adjustments. [1] [2]

Enhanced Dark Mode Support

  • Overhauled css/darkmode.css to use the new variables, update Bootstrap dark theme variables, and add targeted component overrides (for cards, modals, dropdowns, buttons, jsTree, autocomplete, etc.) for a more polished and accessible dark mode.

Component-Specific Style Refactoring

  • Refactored buttons, alerts, tooltips, badges, and form controls in css/gfz-cd.css and css/help.css to use the new custom properties, ensuring consistent styling across components and between themes. [1] [2] [3] [4] [5]

Improved Footer and Layout Responsiveness

  • Updated footer and body padding logic to use CSS variables for dynamic sizing, ensuring the fixed footer does not overlap content and adapts to different devices.

Accessibility and Visual Feedback Improvements

  • Updated focus states, drag-and-drop handles, and input feedback to use theme variables, improving accessibility and visual clarity in both light and dark modes. [1] [2] [3] [4] [5]

Screenshots

Optimized Light Mode

ELMO

elmo-light

Guide

elmo-light-guide

Optimized Dark Mode

ELMO

elmo-dark

Guide

elmo-dark-guide

Notes for Reviewer

ELMO Guido woes reworked on top.

Checklist

Branching Strategy:

If this is a hotfix: The branch was created from main and will be merged into main.
If this is a feature or documentation change: The branch was created from dev and will be merged into dev.
If this is a feature or documentation branch, I have pulled the latest changes from main into my branch.

Code Quality

  • My code follows the style guide.
  • I have self-reviewed my code.
  • I added comments for hard-to-understand code.
  • My changes do not create new warnings in the browser console.

Documentation

  • If applicable, PHP code is documented using PHPDoc.
  • If applicable, JavaScript code is documented using JSDoc.
  • If needed, the ELMO Guide ('./doc/help.html') has been updated.
  • If needed, the README has been updated.
  • If needed, the API documentation ('./api/v2/docs') has been updated.
  • If a new feature was added or a bug fixed, the changelog ('./doc/changelog.html') has been updated.

Testing

  • If needed, Playwright tests have been updated or added.
  • If needed, unit tests have been updated or added.
  • If needed, jest tests have been updated or added.

Known Issues

None.

@McNamara84 McNamara84 added this to the v2.2.0 milestone Oct 9, 2026
@McNamara84 McNamara84 self-assigned this Oct 9, 2026
@McNamara84 McNamara84 added bug Etwas funktioniert nicht Dokumentation Verbesserung und Erweiterung der Dokumentation All ELMOs labels Oct 9, 2026
@McNamara84
McNamara84 marked this pull request as ready for review October 9, 2026 10:36
@McNamara84 McNamara84 linked an issue Oct 9, 2026 that may be closed by this pull request
4 tasks
@McNamara84
McNamara84 requested a review from Daetha October 9, 2026 10:42
Comment thread css/tagify-adj.css Outdated
Comment thread doc/help.html
@Daetha

Daetha commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

The Ror and ORCID logos are not visible, but it's ok. There is not much we can do about it. Giving them white background is a worse option.

Bildschirmfoto 2026-10-09 um 15 21 22

@Daetha Daetha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks astonishing and stilish. Re-using colors as variables in css is a big step towards maintainability. Approved

Introduce --elmo-brand-color and reuse it across buttons, backgrounds, dropdowns, and Tagify styling. Keep brand blue fixed for white-text contrast while heading colors remain theme-aware.
@McNamara84
McNamara84 merged commit 6ca3dac into dev Oct 9, 2026
8 checks passed
@McNamara84
McNamara84 deleted the fix/issue-1247 branch October 9, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

All ELMOs bug Etwas funktioniert nicht Dokumentation Verbesserung und Erweiterung der Dokumentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistences in dark theme: page header and buttons

2 participants