Skip to content

Improve playwright testing on ELMO-GEM stage. - #1263

Open
Daetha wants to merge 8 commits into
devfrom
fix/elmogem-tests-on-stage
Open

Daetha wants to merge 8 commits into
devfrom
fix/elmogem-tests-on-stage

Conversation

@Daetha

@Daetha Daetha commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Runnung playwright tests on stage showed no blocking bugs, but some tests were red.

Changes

  • switched the tests to
    page.goto(''); instead page.goto('/'); to resolve to icgem-test/elmo correctly
  • REPO_ROOT to be able to run tests from other directories
  • contrast of a gfc. upload button is improved

Notes for Reviewer

[Describe the steps needed to test this]

Checklist

Branching Strategy:

If this is a hotfix: The branch was created from main and will be merged into main.
If this is a feature or documentation change: The branch was created from dev and will be merged into dev.
If this is a feature or documentation branch, I have pulled the latest changes from main into my branch.

Code Quality

  • My code follows the style guide.
  • I have self-reviewed my code.
  • I added comments for hard-to-understand code.
  • My changes do not create new warnings in the browser console.

Documentation

  • If applicable, PHP code is documented using PHPDoc.
  • If applicable, JavaScript code is documented using JSDoc.
  • If needed, the ELMO Guide ('./doc/help.html') has been updated.
  • If needed, the README has been updated.
  • If needed, the API documentation ('./api/v2/docs') has been updated.
  • If a new feature was added or a bug fixed, the changelog ('./doc/changelog.html') has been updated.

Testing

  • If needed, Playwright tests have been updated or added.
  • If needed, unit tests have been updated or added.
  • If needed, jest tests have been updated or added.

Known Issues

[What lower priority problems remain?]

@Daetha
Daetha requested a review from McNamara84 October 9, 2026 12:02
@Daetha Daetha self-assigned this Oct 9, 2026
@Daetha Daetha added the ELMO-GEM label Oct 9, 2026
@Daetha Daetha added this to the v2.2.0 milestone Oct 9, 2026

@McNamara84 McNamara84 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Daetha ,

when the mouse hovers over the GFC upload button, the text and background remain blue; the contrast drops to 1:1. This should be fixed and then you can merge.

Best,
Holger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants