Skip to content

Fix: set up front-end validation in feedback modal - #1257

Open
Daetha wants to merge 9 commits into
devfrom
fix/issue-1137
Open

Daetha wants to merge 9 commits into
devfrom
fix/issue-1137

Conversation

@Daetha

@Daetha Daetha commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #1137

Changes

Implemented simple logic: if all the fields are empty, don't send the POST request.

Notes for Reviewer

submit en empty feedback -> check container logs

Checklist

Branching Strategy:

If this is a hotfix: The branch was created from main and will be merged into main.
If this is a feature or documentation change: The branch was created from dev and will be merged into dev.
If this is a feature or documentation branch, I have pulled the latest changes from main into my branch.

Code Quality

  • My code follows the style guide.
  • I have self-reviewed my code.
  • I added comments for hard-to-understand code.
  • My changes do not create new warnings in the browser console.

Documentation

  • If applicable, PHP code is documented using PHPDoc.
  • If applicable, JavaScript code is documented using JSDoc.
  • If needed, the ELMO Guide ('./doc/help.html') has been updated.
  • If needed, the README has been updated.
  • If needed, the API documentation ('./api/v2/docs') has been updated.
  • If a new feature was added or a bug fixed, the changelog ('./doc/changelog.html') has been updated.

Testing

  • If needed, Playwright tests have been updated or added.
  • If needed, unit tests have been updated or added.
  • If needed, jest tests have been updated or added.

Known Issues

[What lower priority problems remain?]

@Daetha Daetha added this to the v2.2.0 milestone Oct 5, 2026
@Daetha Daetha self-assigned this Oct 5, 2026
@Daetha Daetha added Infos ausstehend Issue enthällt offene Fragen die zunächst geklärt werden müssen All ELMOs labels Oct 5, 2026
@McNamara84 McNamara84 linked an issue Oct 6, 2026 that may be closed by this pull request
@Daetha Daetha removed the Infos ausstehend Issue enthällt offene Fragen die zunächst geklärt werden müssen label Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback form sends a POST even when all fields are empty

1 participant