catalog: Better escaping of names in SQL#36132
Merged
def- merged 1 commit intoMaterializeInc:mainfrom Apr 20, 2026
Merged
Conversation
Follow-up to MaterializeInc#35819
def-
changed the title
teskje
reviewed
Apr 17, 2026
Contributor
teskje
left a comment
teskje
left a comment
There was a problem hiding this comment.
Hm, I did consider this but then thought it unnecessary because we control these names and I don't foresee us ever putting special characters in them. Am I missing something?
Contributor
Author
Who knows! I'd rather have a layer extra instead of depending on that without having it forbidden technically. |
Contributor
|
Fair enough! |
teskje
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #35819