Repository navigation
feat(settings): a Plugins page for the built-ins - #138
Merged
Merged
Conversation
…tivities and privacy
…s own switch The features that can be turned off move from Behavior to a new Plugins page: one row each with its icon and what it does, its on/off switch, and its settings inside. config.toml keeps its tables and keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings window gets a Plugins page between Behavior and Home. Every built-in that can be turned off moves there from Behavior: one row each with its icon, what it does and its on/off switch, opening on its own settings (an
Adw.ExpanderRowon GNOME, a card with a disclosure on Windows). Built-ins without settings are plain switch rows; the focus timer has no switch and only opens.config.toml, the daemon and the D-Bus contract do not change: the groups keep their tables and keys, and
Groupgainsiconandmaster(its first row is the switch).This is the first step toward add-on plugins, which will list on the same page.
tools/precheck.sh --quick, desktop check/lint/test, Windows page shot, GNOME window in the devshell.