Add test coverage for duplicate license file prevention#39
Closed
Copilot wants to merge 4 commits into
Closed
Conversation
- Add AckGenCLI dependency to test target - Create DuplicateLicenseFileTests.swift with 4 comprehensive tests - Tests verify that break statement prevents duplicate acknowledgements - Tests simulate SPM checkout directory structure with multiple license files Co-authored-by: MartinP7r <2669027+MartinP7r@users.noreply.github.com>
The tests only use AckGenCore types and simulate CLI logic inline, so the AckGenCLI dependency is not needed. Co-authored-by: MartinP7r <2669027+MartinP7r@users.noreply.github.com>
- Extract scanning logic into scanForLicenses helper method - Rename 'fman' to 'fileManager' for clarity - Add shouldBreak parameter to test both correct and buggy behavior - Reduces code duplication across test methods Co-authored-by: MartinP7r <2669027+MartinP7r@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add a test for SwiftArgumentParser migration changes
Add test coverage for duplicate license file prevention
Feb 7, 2026
MartinP7r
added a commit
that referenced
this pull request
Mar 8, 2026
Verifies that only one acknowledgement is created per package when multiple license file variants exist (LICENSE, LICENSE.txt, LICENSE.md). Closes #39
2 tasks
Owner
|
Closing in favor of #42 which applies these tests rebased onto current main. Cleaned up slightly (removed redundant comments, simplified helper). All tests pass. |
MartinP7r
added a commit
that referenced
this pull request
Mar 8, 2026
Verifies that only one acknowledgement is created per package when multiple license file variants exist (LICENSE, LICENSE.txt, LICENSE.md). Closes #39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback requesting tests for the
breakstatement added in a0ea75c that prevents duplicate acknowledgements when packages contain multiple license files (LICENSE, LICENSE.txt, LICENSE.md).Changes
DuplicateLicenseFileTests.swift: Three test cases validating the fix:
break→ duplicate entries createdscanForLicenses(shouldBreak:): Helper method simulating CLI scanning logic using temporary SPM checkout directories, tests both correct and buggy behavior paths
Test Approach
Tests compile on Linux but require macOS to run (SwiftUI dependency in package).
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.