Implement case-insensitive sorting for Acknowledgement#38
Closed
Copilot wants to merge 3 commits into
Closed
Conversation
Co-authored-by: MartinP7r <2669027+MartinP7r@users.noreply.github.com>
Co-authored-by: MartinP7r <2669027+MartinP7r@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update for case-insensitive handling based on review feedback
Implement case-insensitive sorting for Acknowledgement
Feb 7, 2026
MartinP7r
added a commit
that referenced
this pull request
Mar 8, 2026
Replace inconsistent sorting: Comparable used case-sensitive comparison while all() used .lowercased(). Now both use localizedStandardCompare via the Comparable conformance, which handles locale-specific ordering. Closes #38
2 tasks
Owner
MartinP7r
added a commit
that referenced
this pull request
Mar 8, 2026
Replace inconsistent sorting: Comparable used case-sensitive comparison while all() used .lowercased(). Now both use localizedStandardCompare via the Comparable conformance, which handles locale-specific ordering. Closes #38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Acknowledgementtype'sComparableimplementation was case-sensitive, conflicting with the intended case-insensitive behavior and causing inconsistency with documentation examples.Changes:
Acknowledgement.Comparable: UselocalizedStandardCompare(_:)for case-insensitive comparison (more performant than.lowercased())Acknowledgement.all(): Simplify to use.sorted()directly, delegating toComparabletestSortingIsCaseSensitive→testSortingIsCaseInsensitivewith updated expectationsimprovement-plan.mdexample to reflect case-insensitive behaviorBefore:
After:
Sorting now correctly orders: ["apple", "Banana", "Zebra"] regardless of capitalization.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.