Skip to content

Remove test helper in favor of explicit path construction #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinP7r merged 2 commits into from
Feb 6, 2026
Merged

Remove test helper in favor of explicit path construction #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abec41a
Initial plan
Copilot Feb 6, 2026
16d3b5f
Remove helper method and make path construction explicit in tests
Copilot Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions Tests/AckGenTests/AcknowledgementAllTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,10 @@ import XCTest

final class AcknowledgementAllTests: XCTestCase {

/// Helper to load acknowledgements from the Fixtures subdirectory
private func loadAcknowledgementsFromFixture(plistName: String) -> [Acknowledgement] {
return Acknowledgement.all(fromPlist: "Fixtures/\(plistName)", in: Bundle.module)
}

func testAllDecodesFixturePlist() {
// Given: A fixture plist in the test bundle's Fixtures directory
// When: Loading acknowledgements from the fixture
let acks = loadAcknowledgementsFromFixture(plistName: "Acknowledgements")
let acks = Acknowledgement.all(fromPlist: "Fixtures/Acknowledgements", in: Bundle.module)

// Then: All entries should be decoded correctly
XCTAssertEqual(acks.count, 3)
Expand All @@ -37,7 +32,7 @@ final class AcknowledgementAllTests: XCTestCase {
func testAllSortsCaseInsensitively() {
// Given: A fixture plist with mixed case titles (Zebra, apple, Banana)
// When: Loading acknowledgements (which applies case-insensitive sorting)
let acks = loadAcknowledgementsFromFixture(plistName: "Acknowledgements")
let acks = Acknowledgement.all(fromPlist: "Fixtures/Acknowledgements", in: Bundle.module)

// Then: Should be sorted case-insensitively: apple, Banana, Zebra
XCTAssertEqual(acks.count, 3)
Expand All @@ -63,7 +58,7 @@ final class AcknowledgementAllTests: XCTestCase {
// The all() method should return empty array for any decode failure

// When: Attempting to decode a plist with invalid UTF-8 content
let acks = loadAcknowledgementsFromFixture(plistName: "invalid-utf8-license")
let acks = Acknowledgement.all(fromPlist: "Fixtures/invalid-utf8-license", in: Bundle.module)

// Then: Should return empty array instead of crashing
XCTAssertTrue(acks.isEmpty)
Expand Down