Skip to content

Move pre-flight checks to Requires= - #24042

Merged
Fryguy merged 1 commit into
ManageIQ:masterfrom
agrare:only_start_evmserverd_after_successful_ready_scripts
Nov 2, 2026
Merged

Fryguy merged 1 commit into
ManageIQ:masterfrom
agrare:only_start_evmserverd_after_successful_ready_scripts

Conversation

@agrare

@agrare agrare commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

The systemd After= directive just waits for the listed units to exit, it does not require that those units have succeeded.

Requires=
  Similar to Wants=, but declares a stronger requirement dependency.

Running evmserverd when manageiq-messaging-ready will fail:

[root@miq-rhel10-fips ~]# systemctl start evmserverd
A dependency job for evmserverd.service failed. See 'journalctl -xe' for details.
journalctl -f
Nov 02 10:43:49 miq-rhel10-fips.localdomain systemd[1]: manageiq-messaging-ready.service: Main process exited, code=exited, status=1/FAILURE
Nov 02 10:43:49 miq-rhel10-fips.localdomain systemd[1]: manageiq-messaging-ready.service: Failed with result 'exit-code'.
Nov 02 10:43:49 miq-rhel10-fips.localdomain systemd[1]: Failed to start manageiq-messaging-ready.service - ManageIQ Messaging Ready.
Nov 02 10:43:49 miq-rhel10-fips.localdomain systemd[1]: Dependency failed for evmserverd.service - EVM server daemon.
Nov 02 10:43:49 miq-rhel10-fips.localdomain systemd[1]: evmserverd.service: Job evmserverd.service/start failed with result 'dependency'.

The systemd `After=` directive just waits for the listed units to exit,
it does not require that those units have succeeded.

```
Requires=
  Similar to Wants=, but declares a stronger requirement dependency.
```
@agrare
agrare requested a review from Fryguy as a code owner October 30, 2026 19:16
@miq-bot miq-bot added the wip label Oct 30, 2026
@miq-bot

miq-bot commented Oct 30, 2026

Copy link
Copy Markdown
Member

Checked commit agrare@47b9eb9 with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1
0 files checked, 0 offenses detected
Everything looks fine. 👍

@agrare agrare changed the title [WIP] Move pre-flight checks to Requires= Move pre-flight checks to Requires= Nov 2, 2026
@miq-bot miq-bot removed the wip label Nov 2, 2026
@Fryguy
Fryguy merged commit 4aafc1a into ManageIQ:master Nov 2, 2026
6 checks passed
@Fryguy Fryguy self-assigned this Nov 2, 2026
@agrare
agrare deleted the only_start_evmserverd_after_successful_ready_scripts branch November 2, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants