Repository navigation
Fix get_owner to fall back to requester_group when owner_group is absent - #24002
Merged
agrare merged 1 commit intoOct 17, 2026
Merged
Conversation
Fryguy
changed the title
A user can switch their active group between submitting a provisioning request and the time the worker runs. When that happens, vm.miq_group should reflect the group that was active at request time, not whatever the DB says when the task executes. set_request_values always stamps requester_group on new requests, making it the authoritative record of the request-time group. get_owner already uses owner_group for the same purpose when present, but had no fallback when it was absent -- leaving set_ownership to silently use user.current_group from the live DB. Using requester_group as the fallback closes that gap. CP4AIOPS-37102
jrafanie
force-pushed
the
fix-vm-provisioning-owning-group
branch
from
October 16, 2026 20:29
789e196 to
e2bb25a
Compare
jrafanie
changed the title
jrafanie
changed the title
Member
|
Checked commit jrafanie@e2bb25a with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1 |
Member
|
@agrare Please review. |
agrare
approved these changes
Oct 17, 2026
Member
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Oct 19, 2026
Fix get_owner to fall back to requester_group when owner_group is absent (cherry picked from commit 7a0171b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user can switch their active group between submitting a provisioning
request and the time the worker runs. When that happens, vm.miq_group
should reflect the group that was active at request time, not whatever
the DB says when the task executes.
set_request_values always stamps requester_group on new requests, making
it the authoritative record of the request-time group. get_owner already
uses owner_group for the same purpose when present, but had no fallback
when it was absent -- leaving set_ownership to silently use
user.current_group from the live DB.
Using requester_group as the fallback closes that gap.
CP4AIOPS-37102