Repository navigation
Fix the service filtering for many services - #2215
Conversation
|
@jrafanie, I created this fix for #2095. This is mainly an API/Core issue since the filtering does work but the issue is here because there is so many services that it fails due to having to do the child searches for each item. Please review this PR and the dependent PRs: ManageIQ/manageiq#23995 and ManageIQ/manageiq-api#1345. I am not too familiar with the API or core code here, so if you feel this change is incorrect, feel free to close my PRs and use the correct fix. |
|
Holding off on this PR for now as we wait for core PR to merge |
|
@Fryguy I fixed the console issue; this PR should be ready now |
Fryguy
left a comment
There was a problem hiding this comment.
LGTM - we just need to fix the security suite first.
6dc2d2d to
d5cd61d
Compare
|
Checked commits GilbertCherrie/manageiq-ui-service@9882530~...d5cd61d with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1 |
Fix the service filtering for many services (cherry picked from commit 57ac469)
|
Backported to |
Fixes: #2095
Depends on:
Replace all_service_children (full recursive data for every service) with v_total_direct_service_children (a count) in the list query. Children are now fetched lazily, only when a user expands a row, via a new getServiceChildren() call filtered by service_id.