Skip to content

Fix the service filtering for many services - #2215

Merged
Fryguy merged 2 commits into
ManageIQ:masterfrom
GilbertCherrie:fix-filter-service
Oct 6, 2026
Merged

Fryguy merged 2 commits into
ManageIQ:masterfrom
GilbertCherrie:fix-filter-service

Conversation

@GilbertCherrie

@GilbertCherrie GilbertCherrie commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Fixes: #2095

Depends on:

Replace all_service_children (full recursive data for every service) with v_total_direct_service_children (a count) in the list query. Children are now fetched lazily, only when a user expands a row, via a new getServiceChildren() call filtered by service_id.

@GilbertCherrie

Copy link
Copy Markdown
Member Author

@jrafanie, I created this fix for #2095. This is mainly an API/Core issue since the filtering does work but the issue is here because there is so many services that it fails due to having to do the child searches for each item. Please review this PR and the dependent PRs: ManageIQ/manageiq#23995 and ManageIQ/manageiq-api#1345. I am not too familiar with the API or core code here, so if you feel this change is incorrect, feel free to close my PRs and use the correct fix.

@GilbertCherrie

Copy link
Copy Markdown
Member Author

Holding off on this PR for now as we wait for core PR to merge

@GilbertCherrie

Copy link
Copy Markdown
Member Author

@Fryguy I fixed the console issue; this PR should be ready now

@Fryguy Fryguy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we just need to fix the security suite first.

@Fryguy
Fryguy merged commit 57ac469 into ManageIQ:master Oct 6, 2026
2 checks passed
@miq-bot

miq-bot commented Oct 6, 2026

Copy link
Copy Markdown
Member

Checked commits GilbertCherrie/manageiq-ui-service@9882530~...d5cd61d with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1
0 files checked, 0 offenses detected
Everything looks fine. ⭐

@GilbertCherrie
GilbertCherrie deleted the fix-filter-service branch October 6, 2026 21:12
@Fryguy Fryguy added tal/yes and removed tal/yes? labels Oct 7, 2026
bdunne pushed a commit that referenced this pull request Oct 7, 2026
Fix the service filtering for many services

(cherry picked from commit 57ac469)
@bdunne

bdunne commented Oct 7, 2026

Copy link
Copy Markdown
Member

Backported to tal in commit 43474ea.

commit 43474ea20787e43001e50d1fa835c1ac9176bd79
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Oct 6 17:11:06 2026 -0400

    Merge pull request #2215 from GilbertCherrie/fix-filter-service
    
    Fix the service filtering for many services
    
    (cherry picked from commit 57ac46939b1912f657accf638c333dbba8448a79)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service filtering does not work in UI service

5 participants