Repository navigation
Add snapshot rename action for VM and Instance snapshots - #1343
Conversation
|
@prashantsrivastava6 Cannot apply the following label because they are not recognized:
All labels for |
|
@prashantsrivastava6 I don't know what 1418 is but can you update the PR description so that it is more helpful/readable? |
|
@miq-bot cross-repo-tests ManageIQ/manageiq#23986 |
prashantsrivastava6
changed the title
@agrare I've updated the title and description to better describe the purpose of the PR. |
|
Core PR merged, FYI this failed on cross-repo https://github.com/ManageIQ/manageiq-cross_repo-tests/actions/runs/37003078981/job/110825009111?pr=1083 so it will likely fail the same way here |
a1c0f41 to
40456b5
Compare
| vm = FactoryBot.create(:vm_vmware, :name => "Alice's VM", :host => host, :ext_management_system => ems) | ||
| snapshot = FactoryBot.create(:snapshot, :name => "Alice's snapshot", :vm_or_template => vm) | ||
|
|
||
| allow(vm).to receive(:supports?).with(:rename_snapshot).and_return(true) |
There was a problem hiding this comment.
We have stub_supports for this, look around in these specs there are lots of examples
40456b5 to
cebefd9
Compare
cebefd9 to
045ac3a
Compare
|
Checked commits prashantsrivastava6/manageiq-api@15e3cc1~...045ac3a with ruby 3.3.12, rubocop 1.91.0, haml-lint 0.78.0, and yamllint 1.37.1 |
|
@prashantsrivastava6 you have to update the API documentation as well, https://github.com/ManageIQ/manageiq-documentation/tree/master/api/reference |
Summary of Changes
This PR adds support for renaming snapshots via the REST API for Virtual Machines and Instances.
Changes
config/api.yml
rename_snapshotunder snapshot subcollection actions for both VMs and Instancesvm_snapshot_renameproduct feature for VMscloud_volume_snapshot_controlfor Instancesapp/controllers/api/subcollections/snapshots.rb
snapshots_rename_snapshot_resourcenameparameterparent.supports?(:rename_snapshot)before queuingems_operationsrolespec/requests/snapshots_spec.rb
Related PRs / Issues
@miq-bot add-label enhancement