Repository navigation
docs(specs): fixed-lot credit trading with HTLC recovery - #1041
Closed
maxie-agent wants to merge 4 commits into
Closed
maxie-agent wants to merge 4 commits into
maxie-agent wants to merge 4 commits into
Conversation
|
@maxie-agent is attempting to deploy a commit to the MakePrisms Team on Vercel. A member of the Team first needs to authorize it. |
maxie-agent
force-pushed
the
docs/credit-trading
branch
from
October 7, 2026 19:45
9f17266 to
dcb98c3
Compare
This was referenced Oct 7, 2026
Collaborator
Author
|
Replaced by #1106 (same commit, now on a MakePrisms branch so Vercel previews run). |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only refresh of #1041
Refresh requested by Bob in #cashu-token-marketplace, 2026-10-07 19:37 UTC. Rebased the existing
maxie-agent:docs/credit-tradingdraft onto current main. Onlydocs/specs/credit-trading.mddiffers from main; the probe is throwaway/uncommitted. No merge, runtime implementation, production relay writes or real-money operations.Single anchor:
8c3bf74f87ca4e5d0f7b0bff64c41a7073ac849e.What changed since
9f17266expbefore publication and fence onexp + skew, then reconcile state/restore. Main'supdated_at + 300sestimate is not sufficient for the proposed trade contract. nostr:// recovery: fence on a persisted request exp instead of updated_at + 300s #1035 remains open; Flaky test: maxplayer-mint killed_mid_swap_is_compensated_on_restart_then_executes (no reply after restart) #1090's sidecar flake and Enforce sealed delivery_mint at pay; journalled supersession for re-planned binds #1101's sealed delivery-mint issue remain explicit integration boundaries.Bob's decisions
Settled in §0, attributed to Bob, #cashu-token-marketplace, 2026-10-07:
required_scope_for_kindunderScope::MessagesWritebefore clients use the feature; 23412 ephemeral. Anchor search confirms no product allocation (3410 only in an unknown-kind negative test); global registry/rollout review remains.Settled — Q2/Q3 (Bob, #cashu-token-marketplace, 2026-10-07 19:40 UTC)
Probe results — 2026-10-07
CDK/Cashu/CDK-common/CDK-sqlite/CDK-fake-wallet all
=0.17.2; real local SQLite sidecar and native wallets, direct in-process connector. Copied source byte-compared against anchor (dispatch import only adapted). The first build exposed the wire module's new shared-crate dependency; copied that exact crate into tmp and reran successfully.sidecar_htlc_probe: 1 passed, 0 failed; 5 helper tests filtered out; 5.04 s runtime. Cargo 1.98.1 + Nix protoc. One harmless standalonegatewaycfg warning.receivewith refund key but no preimage returnsPreimage not provided. Lower-level signed swap works; durable refund adapter still requiredSWAP and CHECKSTATE dispatch forwarding exercised. Local artifacts:
~/.openclaw/workspace/.openclaw/tmp/credit-htlc-probe/(refresh-20261007.log,citation-audit.json, exact copied source and test).Not verified: full two-mint atomic swap; encrypted/production relay delivery; killed-process recovery; persisted-exp integration or durable refund-output storage; positive fees; cross-mint clock skew/processing bounds; production-length outage behavior; key rotation; live Minibits/other mint claim/refund/witness behavior. Historical 24 Sep Minibits info remains labeled historical, not refreshed certification. Repository runtime suites not run for this docs-only change. Mermaid source reviewed; rendered GitHub visualization unverified.
Self-review: flaws fixed vs risks accepted
Fixed in the spec: stale anchors/unmerged framing; missing credits-first consequences; tested-only gate contrary to Q4; stale Q2/Q3 pending markers (approved by Bob at 19:40 UTC); stale 2h cutoff/five-minute hold; automatic-refund assumptions; recovery reuse without persisted-exp fences; stale sidecar info evidence. Existing asset-qualified caps, exact proof conditions, fee-inclusive quotes, wallet-wide reservations, single-fill CAS, idempotent journal and unchanged job platform fees remain intact.
Accepted/remaining risks: advertised-but-broken mint behavior; issuer fraud; late-claim/refund races and outages beyond the bounded gap; maker's witness dependency; funded free options/Sybil holds; single-relay censorship and metadata exposure; cloned-wallet spends/key loss; fee increases blocking capped recovery. The canary narrows exposure, not universal mint trust.
git diff --checkand anchored citation/copy audits pass. Stages stay default-off. Keep draft; no canary runs without Bob's separate go. Still open: who deploys the 3410/3411 relay change.