Internalize provisioning + session.established event - #1171
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
jbojcic1
reviewed
Jul 28, 2026
jbojcic1
reviewed
Jul 28, 2026
jbojcic1
reviewed
Jul 28, 2026
Collaborator
There was a problem hiding this comment.
should we move this and pendingGiftCardMintTermsAcceptedAt related code after these cache prefetches since they are only needed down there were acceptTerms is called?
Contributor
Author
There was a problem hiding this comment.
Agreed — pure locality move. The storage get/remove is independent of the prefetches, so reordering doesn't change behavior; it just puts the pending-terms reads next to the acceptTerms call that uses them. I'll fold it in.
Contributor
Author
There was a problem hiding this comment.
Done in 2aff3f6 — pure move, the pending-terms reads now sit right above the acceptTerms block. Read/remove logic unchanged.
Provisioning moves out of the web host into the SDK, fired on auth
session-start and guarded by an in-memory identity fingerprint. The host
seeds its caches from a new replay-latest auth.session-started event
instead of orchestrating provisioning itself.
SDK:
- Provision the settled user post-establish on every auth transition
(signUp / signInGuest / signIn / restore / mid-session change),
fingerprint-guarded (userId, email, emailVerified) so it re-runs only on
an identity change. Master's failure behavior is preserved: upsert via
withRetry, no retry on ZodError, terminal failure throws.
- New auth.session-started event { user, accounts } with replay-latest;
events.clear() drops all retained replay payloads on session end.
- acceptTerms(timestamp) decoupled from provision; the host stamps the
real acceptance time.
- createUserProvisioner owns the fingerprint guard and its reset;
auth-service only notifies that a session started and the SDK layer
decides that means provisioning.
- accounts.list() and the event return bare Account[]; getExtendedAccounts
stays exported as a caller-side selector for isDefault (see #1170).
Web:
- Delete the hasUserChanged gate and ensureUserData provisioning from
_protected.tsx; a boot-registered session-started consumer seeds the
user + accounts caches.
- Restore path re-throws a terminal provision failure to the error
boundary (matches live), booting anonymous only on a genuine restore
failure.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
orveth
force-pushed
the
sdk/provision-internalization
branch
from
July 28, 2026 13:20
2aff3f6 to
973f625
Compare
jbojcic1
approved these changes
Jul 28, 2026
orveth
added a commit
that referenced
this pull request
Jul 28, 2026
…and provisioning Extracts the accounts slice of the wallet into @agicash/wallet-sdk: the web app reads accounts, session keys, user, and provisioning through the SDK contract instead of owning that logic. - accounts namespace (sdk.accounts.*) backed by an in-SDK repository, with a /temporary bridge for repositories not yet migrated. - session-scoped key plumbing: derivation memos fenced by an AbortController scope and revocable on session end; web key queries call the derivation leaves directly. - user provisioning internalized on the auth lifecycle, fingerprint-guarded, fired on a replay-latest auth.session-started event the host seeds its caches from; acceptTerms decoupled from provision. - session-lifecycle hardening: typed SessionEndedError / DisposedError, terminal dispose, explicit guarded Encryption facade. - accounts.list() and the event return bare Account[]; getExtendedAccounts exported as a caller-side selector for isDefault (see #1170). Squashes #1167 (includes #1168 and #1171). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jbojcic1
pushed a commit
that referenced
this pull request
Jul 28, 2026
…and provisioning Extracts the accounts slice of the wallet into @agicash/wallet-sdk: the web app reads accounts, session keys, user, and provisioning through the SDK contract instead of owning that logic. - accounts namespace (sdk.accounts.*) backed by an in-SDK repository, with a /temporary bridge for repositories not yet migrated. - session-scoped key plumbing: derivation memos fenced by an AbortController scope and revocable on session end; web key queries call the derivation leaves directly. - user provisioning internalized on the auth lifecycle, fingerprint-guarded, fired on a replay-latest auth.session-started event the host seeds its caches from; acceptTerms decoupled from provision. - session-lifecycle hardening: typed SessionEndedError / DisposedError, terminal dispose, explicit guarded Encryption facade. - accounts.list() and the event return bare Account[]; getExtendedAccounts exported as a caller-side selector for isDefault (see #1170). Squashes #1167 (includes #1168 and #1171). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves provisioning into the SDK on the auth lifecycle and adds a
session.establishedevent so the host seeds its caches by plain reads. Removes the web-side provisioning orchestration.SDK
(userId, email, emailVerified)so it re-runs only on identity change.withRetry(2×), no retry onZodError, terminal failure throws. On restore that surfaces the error boundary, as live does today.session.establishedevent{ user, accounts }with replay-latest (a late subscriber gets the current payload immediately); cleared on session end.acceptTerms(timestamp)decoupled from provision — the host stamps the real click timestamp.accounts.list()andsession.establishedreturn bareAccount[];getExtendedAccountsstays exported as a caller-side selector forisDefault. See Accounts — make isDefault a first-class, SDK-owned field with change notification #1170 for the deferred design that would makeisDefaulta first-class SDK-owned field with change notification.Web
hasUserChangedgate andensureUserData's provisioning call from_protected.tsx— provisioning is SDK-internal now.session.establishedconsumer seedsUserCache+AccountsCachefrom the event at boot.acceptTermswith the real click timestamp.Verification
fix:allclean · wallet-sdk 132 pass / 0 fail + typecheck green · web 38 pass / 0 fail + typecheck green.session.established(fingerprint + retained-event reset on session end).Sequencing
Merges into
sdk/accounts-slice; accounts-slice + #1167 then go to master as one whole.