Repository navigation
fix(receive): handle tokens with unsupported units gracefully - #1036
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
jbojcic1
reviewed
Apr 30, 2026
gudnuf
commented
May 1, 2026
orveth
force-pushed
the
fix/handle-unsupported-token-unit
branch
from
May 1, 2026 20:50
bf252d5 to
b85038c
Compare
gudnuf
commented
May 1, 2026
Contributor
Author
|
@jbojcic1 i completely changed the approach to just validate the token in the route loader rather than trying to thread unsupported tokens through the actual receive flow |
jbojcic1
reviewed
May 4, 2026
Collaborator
There was a problem hiding this comment.
I would call this unsupported cashu token page. The token is not invalid but just not supported by our wallet atm.
| }; | ||
|
|
||
| const cashuProtocolUnitToCurrency: { | ||
| export const cashuProtocolUnitToCurrency: { |
Collaborator
There was a problem hiding this comment.
I would create some validate token method and export that
| loaderData, | ||
| }: Route.ComponentProps) { | ||
| const { token } = loaderData; | ||
| if (!loaderData.valid) { |
Collaborator
There was a problem hiding this comment.
I'd call this loader data property isTokenSupported
orveth
force-pushed
the
fix/handle-unsupported-token-unit
branch
from
May 6, 2026 17:33
a4d8fcf to
13c7eeb
Compare
Contributor
Author
|
@jbojcic1 I took all your suggestions |
jbojcic1
approved these changes
May 7, 2026
Pasting or deep-linking a Cashu token whose unit isn't sat or usd crashed /receive/cashu/token because tokenToMoney threw synchronously inside render-path hooks. The route loaders now run validateCashuToken right after decode and short-circuit to UnsupportedCashuTokenPage with a reason-specific message. Send flow is unaffected — internally-generated tokens always have a supported unit derived from Currency. validateCashuToken returns a discriminated union so future checks (empty proofs, blocklisted mint, etc.) plug in as additional early-return branches.
orveth
force-pushed
the
fix/handle-unsupported-token-unit
branch
from
May 8, 2026 15:54
13c7eeb to
e2835eb
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On master when a user inputs a token with an unsupported unit the app crashes:
This PR makes the UI handle the error by not building the source account (because we can't convert the token amount to Money) and rendering the error display.
You can test with this token which has a unit of
eur: