refactor: extract shared helper methods for document aggregation and topic naming#2509
Open
pidefrem wants to merge 1 commit into
Open
refactor: extract shared helper methods for document aggregation and topic naming#2509pidefrem wants to merge 1 commit into
pidefrem wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
refactor: extract shared helper methods for document aggregation and topic naming
Several methods in
_bertopic.pycontain near-identical copy-paste patterns that have diverged slightly over time:groupby("Topic").agg({"Document": " ".join})appears in 4 methods (_extract_topics,hierarchical_topics,update_topics,partial_fit). When a new column needs aggregating, every call site must be updated independently.get_feature_namesvsget_feature_names_out) is duplicated inhierarchical_topicsand_c_tf_idf."_".join([x[0] for x in words][:N])appears in 4 places across 2 methods with inconsistent slicing ([:4]intopic_labels_,[:5]inhierarchical_topics).Changes:
Extract three private helper methods:
_aggregate_documents()— centralizes the groupby/agg pattern_get_feature_names()— centralizes the sklearn version check_topic_name_from_words()— centralizes topic name string construction with consistent slicingAll existing call sites updated to use the helpers. Zero behavior change — pure refactoring. All existing tests pass without modification.
Fixes #2497
Before submitting