Skip to content

[DOP-36596] Introduce Samba.Extra class#489

Merged
dolfinus merged 1 commit into
developfrom
improvement/DOP-36596-samba
May 12, 2026
Merged

[DOP-36596] Introduce Samba.Extra class#489
dolfinus merged 1 commit into
developfrom
improvement/DOP-36596-samba

Conversation

@dolfinus
Copy link
Copy Markdown
Member

@dolfinus dolfinus commented Apr 29, 2026

Change Summary

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Apr 29, 2026
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Apr 29, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

Coverage

Coverage Report •
FileStmtsMissBranchBrPartCoverMissing
onetl/connection/file_connection
   samba.py151714195%19–20, 29–30, 230, 289–290
TOTAL103931581186838884% 

@dolfinus dolfinus force-pushed the improvement/DOP-36596-samba branch from f8435aa to 984e718 Compare April 29, 2026 16:13
@dolfinus dolfinus marked this pull request as ready for review April 29, 2026 16:27
Comment thread onetl/connection/file_connection/samba.py Outdated
Comment thread onetl/connection/file_connection/samba.py Outdated
@dolfinus dolfinus force-pushed the improvement/DOP-36596-samba branch from 984e718 to a778f79 Compare May 12, 2026 08:44
@dolfinus dolfinus requested a review from IlyasDevelopment May 12, 2026 08:45
@dolfinus dolfinus force-pushed the improvement/DOP-36596-samba branch 2 times, most recently from ffa63bd to 3a4f908 Compare May 12, 2026 08:46
@dolfinus dolfinus force-pushed the improvement/DOP-36596-samba branch from 3a4f908 to 146e320 Compare May 12, 2026 09:03
@dolfinus dolfinus enabled auto-merge (rebase) May 12, 2026 09:06
@dolfinus dolfinus merged commit 1f78e73 into develop May 12, 2026
30 checks passed
@dolfinus dolfinus deleted the improvement/DOP-36596-samba branch May 12, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants