Skip to content

Improve typing#483

Merged
dolfinus merged 1 commit into
developfrom
improvement/typing
May 12, 2026
Merged

Improve typing#483
dolfinus merged 1 commit into
developfrom
improvement/typing

Conversation

@dolfinus
Copy link
Copy Markdown
Member

@dolfinus dolfinus commented Apr 29, 2026

Change Summary

Previously mypy skipped all files containing file in path, because of custom RemoteFile/RemoteDir/etc classes. Now this exclusion removed, and mypy errors fixed by using TYPE_CHECKING overrides.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Apr 29, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

Coverage

@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Apr 29, 2026
@dolfinus dolfinus marked this pull request as ready for review April 29, 2026 15:38
Comment thread onetl/db/db_writer/db_writer.py
@dolfinus dolfinus force-pushed the improvement/typing branch 2 times, most recently from 1b5d79d to b511135 Compare May 12, 2026 09:32
@dolfinus dolfinus force-pushed the improvement/typing branch from b511135 to 6fae0cf Compare May 12, 2026 09:46
@dolfinus dolfinus merged commit e3c4c49 into develop May 12, 2026
71 checks passed
@dolfinus dolfinus deleted the improvement/typing branch May 12, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants