-
Notifications
You must be signed in to change notification settings - Fork 405
Changes to filename_template checks #1464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
abishekg7
wants to merge
11
commits into
MPAS-Dev:develop
Choose a base branch
from
abishekg7:framework/new_filename_template_check
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−7
Draft
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
30b74f7
first draft
abishekg7 42399bc
Only crash out if it's an output stream
abishekg7 74af38b
Rename subroutine and call from stream_mgr_validate_streams
abishekg7 8eb3e56
Remove commented lines
abishekg7 64e5856
Some cleanups addressing review comments
abishekg7 3bf5404
remove trailing whitespace
abishekg7 5c7a075
Negating if conditions, removing unused variables and whitespace fixes
abishekg7 97c6d25
Edits to pass ierr to calling routine
abishekg7 741c495
Fixes to address review comments, and cleanup of logging statements
abishekg7 035a4a7
Redoing logic
abishekg7 f5e7f5c
Using stream_mgr_get_num_alarms in the logic. And some cleanup
abishekg7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.