Fix: Bugs in windows installer#3061
Conversation
WhoBrokeTheBuild
added
bug
This should hopefully fix MDSplus#3059 Remove auto expand on APIs/python sections of the component selection, it caused the list to jump around in annoying ways Remove "devices" section and move "tdi devices" up one level, and "pydevices" under the Python section Remove complicated logic to trying to keep the python/pydevices sections dependent on each other Try to better select components for each install type
WhoBrokeTheBuild
force-pushed
the
slw-nsi-issues-3059
branch
from
ddafe78 to
57886c5
Compare
|
And these screenshots show that the "custom" installation also works fine. 
|
|
Now that the installation on Windows 11 has been tested, I will review the changes to the *.nsi file. |
| ${IfNot} for AllUsers ? | ||
| ${AddToEnv} "PATH" "${BINDIR}" | ||
| ${EndIf} | ||
| SectionIn 1 2 |
There was a problem hiding this comment.
Minimal install does not append the path (i.e., append is only for "1 2" -- Typical and Full -- installs). Likely is A-OK to exclude Minimal, but am flagging this just to make sure it isn't an oversight.
| ${EndIf} | ||
| SectionSetFlags ${appendpath} ${SF_RO} | ||
| ${SelectSection} ${appendpath} | ||
| ; SectionSetFlags ${appendpath} ${SF_RO} |
There was a problem hiding this comment.
Should this commented line be deleted?
There was a problem hiding this comment.
I'm going to leave them for now, but they can definitely be removed next time someone works on this
| ${EndIf} | ||
| ${EndIf} | ||
| FunctionEnd | ||
| ; Function .onSelChange |
There was a problem hiding this comment.
Perhaps add a comment to explain why this function was commented out and retained? Alternatively, delete the commented function?
There was a problem hiding this comment.
So long as we go through a release cycle and people are happy with the change, I'll probably remove it shortly
|
Hi @WhoBrokeTheBuild -- The changes to the *.nsi file look good and match the PR's description. I only spotted three trivial cosmetic issues. After you respond to the three comments, I'll then submit the approval for the PR. |
mwinkel-dev
left a comment
mwinkel-dev
left a comment
There was a problem hiding this comment.
Replies to comments make sense, thus approving this PR.
2 participants
This should hopefully fix #3059
Remove auto expand on APIs/python sections of the component selection, it caused the list to jump around in annoying ways
Remove "devices" section and move "tdi devices" up one level, and "pydevices" under the Python section
Remove complicated logic to trying to keep the python/pydevices sections dependent on each other
Try to better select components for each install type
Fix issues related to move out of C:\Windows\System32 where the $PATH wasn't being updated for all-user installations