[Docs] Document perfectionEffectOverride and missing CraftingBuff fields#65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation updates based on game changes and code review:
perfectionEffectOverridefield documenting thequalityvalue that makes perfection affect crafted item quality tier (basic/perfect/sublime)effectHintandstatsTooltipfields to the CraftingBuff interface documentation; clarifiedbaseScalingandstacksScalingdescriptionsGame Changes Triggering These Updates
7f557e4aperfectionEffectOverride: qualityin recipes03a861d8perfectionEffectOverrideRotating Review
This run's rotating review covered the crafting area. The review identified:
perfectionEffectOverridewas not documented in recipes.mdeffectHintandstatsTooltipfields on CraftingBuff were missing from buffs.mdBreaking Changes / Important Notes for Modders
perfectionEffectOverride: qualityis used by all bomb recipes. When creating recipes that should affect quality tier rather than stats, set this field.🤖 Mod Documentation Updater — automated AI assistant